summaryrefslogtreecommitdiff
path: root/target/i386
diff options
context:
space:
mode:
authorPaolo Bonzini <pbonzini@redhat.com>2018-11-14 10:48:00 +0100
committerPaolo Bonzini <pbonzini@redhat.com>2018-11-27 15:06:14 +0100
commit5aaac46793828d01c893b9d99d905c657f59541e (patch)
tree6cffbf47336ee06c5a92c247ee6a779e28120f92 /target/i386
parent56333e69ee1855a8fa74b361742a0a79407846d2 (diff)
downloadqemu-5aaac46793828d01c893b9d99d905c657f59541e.zip
migration: savevm: consult migration blockers
There is really no difference between live migration and savevm, except that savevm does not require bdrv_invalidate_cache to be implemented by all disks. However, it is unlikely that savevm is used with anything except qcow2 disks, so the penalty is small and worth the improvement in catching bad usage of savevm. Only one place was taking care of savevm when adding a migration blocker, and it can be removed. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'target/i386')
-rw-r--r--target/i386/kvm.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/target/i386/kvm.c b/target/i386/kvm.c
index 2724800686..b2401d13ea 100644
--- a/target/i386/kvm.c
+++ b/target/i386/kvm.c
@@ -1266,7 +1266,6 @@ int kvm_arch_init_vcpu(CPUState *cs)
if (!env->user_tsc_khz) {
if ((env->features[FEAT_8000_0007_EDX] & CPUID_APM_INVTSC) &&
invtsc_mig_blocker == NULL) {
- /* for migration */
error_setg(&invtsc_mig_blocker,
"State blocked by non-migratable CPU device"
" (invtsc flag)");
@@ -1276,8 +1275,6 @@ int kvm_arch_init_vcpu(CPUState *cs)
error_free(invtsc_mig_blocker);
return r;
}
- /* for savevm */
- vmstate_x86_cpu.unmigratable = 1;
}
}