diff options
author | Andreas Färber <afaerber@suse.de> | 2015-03-17 17:46:36 +0100 |
---|---|---|
committer | Eduardo Habkost <ehabkost@redhat.com> | 2015-06-02 15:15:52 -0300 |
commit | 0e3bd56294230ad0ee20fce587879c29a83a0d8b (patch) | |
tree | a346b021af23426c54d10d3564a1e5de3fc32fb2 /target-i386 | |
parent | 42d58e7c6760cb9c55627c28ae538e27dcf2f144 (diff) | |
download | qemu-0e3bd56294230ad0ee20fce587879c29a83a0d8b.zip |
pc: Ensure non-zero CPU ref count after attaching to ICC bus
Setting the parent bus of a device increases its ref count, which we
ultimately want to level out. However it is only safe to do so after the
last reference to the device in local code, as qom-set or similar operations
might decrease the ref count.
Therefore move the object_unref() from pc_new_cpu() into its callers.
The APIC operations on the last CPU in pc_cpus_init() are still potentially
insecure, but that is beyond the scope of this code movement.
Signed-off-by: Andreas Färber <afaerber@suse.de>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Diffstat (limited to 'target-i386')
0 files changed, 0 insertions, 0 deletions