diff options
| author | Marc-André Lureau <marcandre.lureau@redhat.com> | 2020-01-10 19:30:24 +0400 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2020-01-24 20:59:13 +0100 |
| commit | fc4fe712aed18e0b5b88cfc56769c76d15a6ff66 (patch) | |
| tree | c570c2a0bbf11e9dea4eda5698ba3e8c3e4c8c18 /qom | |
| parent | 0e76ed0a5da4c8540597c1ffac72705e04323f69 (diff) | |
| download | qemu-fc4fe712aed18e0b5b88cfc56769c76d15a6ff66.zip | |
object: do not free class properties
The release callback is called during object_property_del_all(), on a
live instance. But class properties are common among all
instances. It is not currently called, because we don't release
classes, but it would not be correct if we did.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20200110153039.1379601-12-marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'qom')
| -rw-r--r-- | qom/object.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/qom/object.c b/qom/object.c index 2d29019620..864281ecec 100644 --- a/qom/object.c +++ b/qom/object.c @@ -2127,7 +2127,7 @@ object_class_property_add_str(ObjectClass *klass, const char *name, rv = object_class_property_add(klass, name, "string", get ? property_get_str : NULL, set ? property_set_str : NULL, - property_release_str, + NULL, prop, &local_err); if (local_err) { error_propagate(errp, local_err); @@ -2220,7 +2220,7 @@ object_class_property_add_bool(ObjectClass *klass, const char *name, rv = object_class_property_add(klass, name, "bool", get ? property_get_bool : NULL, set ? property_set_bool : NULL, - property_release_bool, + NULL, prop, &local_err); if (local_err) { error_propagate(errp, local_err); @@ -2312,7 +2312,7 @@ object_class_property_add_enum(ObjectClass *klass, const char *name, rv = object_class_property_add(klass, name, typename, get ? property_get_enum : NULL, set ? property_set_enum : NULL, - property_release_enum, + NULL, prop, &local_err); if (local_err) { error_propagate(errp, local_err); @@ -2413,7 +2413,7 @@ object_class_property_add_tm(ObjectClass *klass, const char *name, rv = object_class_property_add(klass, name, "struct tm", get ? property_get_tm : NULL, NULL, - property_release_tm, + NULL, prop, &local_err); if (local_err) { error_propagate(errp, local_err); |