diff options
| author | Eric Blake <eblake@redhat.com> | 2020-03-17 15:17:11 -0500 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2020-03-17 21:50:36 +0100 |
| commit | 08712fcb851034228b61f75bd922863a984a4f60 (patch) | |
| tree | 5233c6156a612b7510ba245d224bc5a759aaaf1e /monitor/misc.c | |
| parent | db2a380c84574d8c76d7193b8af8535234fe5156 (diff) | |
| download | qemu-08712fcb851034228b61f75bd922863a984a4f60.zip | |
net: Track netdevs in NetClientState rather than QemuOpt
As mentioned in the previous patch, our use of QemuOpt group "netdev"
has two purposes: collect the CLI arguments, and serve as a witness
for monitor hotplug actions. As the latter didn't use anything but an
id, it felt rather unclean to have to touch QemuOpts at all when going
through QMP, so let's instead track things with a bool field in
NetClientState.
Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200317201711.322764-3-eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'monitor/misc.c')
| -rw-r--r-- | monitor/misc.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/monitor/misc.c b/monitor/misc.c index 41a86e7012..6c45fa490f 100644 --- a/monitor/misc.c +++ b/monitor/misc.c @@ -2035,13 +2035,11 @@ void netdev_del_completion(ReadLineState *rs, int nb_args, const char *str) count = qemu_find_net_clients_except(NULL, ncs, NET_CLIENT_DRIVER_NIC, MAX_QUEUE_NUM); for (i = 0; i < MIN(count, MAX_QUEUE_NUM); i++) { - QemuOpts *opts; const char *name = ncs[i]->name; if (strncmp(str, name, len)) { continue; } - opts = qemu_opts_find(qemu_find_opts_err("netdev", NULL), name); - if (opts) { + if (ncs[i]->is_netdev) { readline_add_completion(rs, name); } } |