diff options
| author | Gerd Hoffmann <kraxel@redhat.com> | 2021-07-22 09:27:56 +0200 |
|---|---|---|
| committer | Gerd Hoffmann <kraxel@redhat.com> | 2021-07-29 11:18:46 +0200 |
| commit | 5e796671e6b8d5de4b0b423dce1b3eba144a92c9 (patch) | |
| tree | f32f3fa85750a103454b1236aa125183b5ad649a /hw/usb | |
| parent | 8a2d766f05f0b6904e1496c699b2394e278c1926 (diff) | |
| download | qemu-5e796671e6b8d5de4b0b423dce1b3eba144a92c9.zip | |
usbredir: fix free call
data might point into the middle of a larger buffer, there is a separate
free_on_destroy pointer passed into bufp_alloc() to handle that. It is
only used in the normal workflow though, not when dropping packets due
to the queue being full. Fix that.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/491
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210722072756.647673-1-kraxel@redhat.com>
Diffstat (limited to 'hw/usb')
| -rw-r--r-- | hw/usb/redirect.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index 4ec9326e05..1ec909a63a 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c @@ -476,7 +476,7 @@ static int bufp_alloc(USBRedirDevice *dev, uint8_t *data, uint16_t len, if (dev->endpoint[EP2I(ep)].bufpq_dropping_packets) { if (dev->endpoint[EP2I(ep)].bufpq_size > dev->endpoint[EP2I(ep)].bufpq_target_size) { - free(data); + free(free_on_destroy); return -1; } dev->endpoint[EP2I(ep)].bufpq_dropping_packets = 0; |