diff options
| author | Liam Merwick <liam.merwick@oracle.com> | 2019-02-15 13:35:17 +0000 |
|---|---|---|
| committer | Stefan Berger <stefanb@linux.vnet.ibm.com> | 2019-02-24 14:46:14 -0500 |
| commit | 37b55d67c0f001b20b7831db3f9f24f1d453e1de (patch) | |
| tree | 396b6aeb8a2ece8d23cb70a5189604252ad89392 /hw/tpm | |
| parent | 8eb29f1bf5a974dc4c11d2d1f5e7c7f7a62be116 (diff) | |
| download | qemu-37b55d67c0f001b20b7831db3f9f24f1d453e1de.zip | |
tpm_tis: fix loop that cancels any seizure by a lower locality
In tpm_tis_mmio_write() if the requesting locality is seizing
access, any seizure by a lower locality is cancelled. However the
loop doing the seizure had an off-by-one error and the locality
immediately preceding the requesting locality was not being cleared.
This is fixed by adjusting the test in the for loop to check the
localities up to the requesting locality.
Signed-off-by: Liam Merwick <Liam.Merwick@oracle.com>
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Diffstat (limited to 'hw/tpm')
| -rw-r--r-- | hw/tpm/tpm_tis.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c index fd6bb9b59a..61a130beef 100644 --- a/hw/tpm/tpm_tis.c +++ b/hw/tpm/tpm_tis.c @@ -624,7 +624,7 @@ static void tpm_tis_mmio_write(void *opaque, hwaddr addr, } /* cancel any seize by a lower locality */ - for (l = 0; l < locty - 1; l++) { + for (l = 0; l < locty; l++) { s->loc[l].access &= ~TPM_TIS_ACCESS_SEIZE; } |