diff options
| author | Thomas Huth <thuth@redhat.com> | 2018-04-05 11:32:30 +0200 |
|---|---|---|
| committer | Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> | 2018-06-17 11:12:41 +0100 |
| commit | 92b19880f7f9cf7f4a9e00dc3258b8d3aa363e9d (patch) | |
| tree | 4527c4d6dc25043ed7c3ea0630b099cf5c85180b /hw/mem | |
| parent | 2ef2f16781af9dee6ba6517755e9073ba5799fa2 (diff) | |
| download | qemu-92b19880f7f9cf7f4a9e00dc3258b8d3aa363e9d.zip | |
hw/sparc64/sun4u: Fix introspection by converting prom instance_init to realize
The instance_init function of devices should always succeed to be able
to introspect the device. However, the instance_init function of the
"openprom" device can currently fail, for example like this:
$ echo "{'execute':'qmp_capabilities'}"\
"{'execute':'device-list-properties',"\
" 'arguments':{'typename':'openprom'}}" \
| sparc64-softmmu/qemu-system-sparc64 -M sun4v,accel=qtest -qmp stdio
{"QMP": {"version": {"qemu": {"micro": 91, "minor": 11, "major": 2},
"package": "build-all"}, "capabilities": []}}
{"return": {}}
RAMBlock "sun4u.prom" already registered, abort!
Aborted (core dumped)
This should not happen. Fix this problem by moving the affected code from
instance_init into a realize function instead.
Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Diffstat (limited to 'hw/mem')
0 files changed, 0 insertions, 0 deletions