diff options
| author | Markus Armbruster <armbru@redhat.com> | 2013-11-28 17:26:57 +0100 |
|---|---|---|
| committer | Andreas Färber <afaerber@suse.de> | 2013-12-23 00:27:23 +0100 |
| commit | f37a4374bae20ca678b808b5ee32319e943b1b4b (patch) | |
| tree | 1e82e352df86c0a902dbf447079ee8ea45e61a65 /hw/intc | |
| parent | ffa957148698eec9cfdaf6e0c1b43cda8828cd61 (diff) | |
| download | qemu-f37a4374bae20ca678b808b5ee32319e943b1b4b.zip | |
apic: Document why cannot_instantiate_with_device_add_yet
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Andreas Färber <afaerber@suse.de>
Diffstat (limited to 'hw/intc')
| -rw-r--r-- | hw/intc/apic_common.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c index ea420c7188..aaef0543bc 100644 --- a/hw/intc/apic_common.c +++ b/hw/intc/apic_common.c @@ -386,9 +386,13 @@ static void apic_common_class_init(ObjectClass *klass, void *data) dc->vmsd = &vmstate_apic_common; dc->reset = apic_reset_common; - dc->cannot_instantiate_with_device_add_yet = true; /* FIXME explain why */ dc->props = apic_properties_common; idc->init = apic_init_common; + /* + * Reason: APIC and CPU need to be wired up by + * x86_cpu_apic_create() + */ + dc->cannot_instantiate_with_device_add_yet = true; } static const TypeInfo apic_common_type = { |