diff options
| author | Li Qiang <liqiang6-s@360.cn> | 2016-11-01 05:37:57 -0700 |
|---|---|---|
| committer | Gerd Hoffmann <kraxel@redhat.com> | 2017-01-11 09:19:05 +0100 |
| commit | 85d9d044471f93c48c5c396f7e217b4ef12f69f8 (patch) | |
| tree | 8165649602ebe2e1796da2f22b9d2e5e7f7db224 /hw/display/virtio-gpu-3d.c | |
| parent | b44486dfb9447c88e4b216e730adcc780190852c (diff) | |
| download | qemu-85d9d044471f93c48c5c396f7e217b4ef12f69f8.zip | |
virtio-gpu: fix information leak in capset get dispatch
In virgl_cmd_get_capset function, it uses g_malloc to allocate
a response struct to the guest. As the 'resp'struct hasn't been full
initialized it will lead the 'resp->padding' field to the guest.
Use g_malloc0 to avoid this.
Signed-off-by: Li Qiang <liqiang6-s@360.cn>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-id: 58188cae.4a6ec20a.3d2d1.aff2@mx.google.com
[ kraxel: resolved conflict ]
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Diffstat (limited to 'hw/display/virtio-gpu-3d.c')
| -rw-r--r-- | hw/display/virtio-gpu-3d.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c index b13ced38fa..f96a0c2e59 100644 --- a/hw/display/virtio-gpu-3d.c +++ b/hw/display/virtio-gpu-3d.c @@ -379,7 +379,7 @@ static void virgl_cmd_get_capset(VirtIOGPU *g, return; } - resp = g_malloc(sizeof(*resp) + max_size); + resp = g_malloc0(sizeof(*resp) + max_size); resp->hdr.type = VIRTIO_GPU_RESP_OK_CAPSET; virgl_renderer_fill_caps(gc.capset_id, gc.capset_version, |