diff options
| author | Markus Armbruster <armbru@redhat.com> | 2019-08-12 07:23:50 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2019-08-16 13:31:52 +0200 |
| commit | db725815985654007ade0fd53590d613fd657208 (patch) | |
| tree | e39bcf77a808fa0002cea415b2a487cf5c7eaf4b /hw/block | |
| parent | dc5e9ac716c5c5312ab29fb9f311f8176064fe04 (diff) | |
| download | qemu-db725815985654007ade0fd53590d613fd657208.zip | |
Include qemu/main-loop.h less
In my "build everything" tree, changing qemu/main-loop.h triggers a
recompile of some 5600 out of 6600 objects (not counting tests and
objects that don't depend on qemu/osdep.h). It includes block/aio.h,
which in turn includes qemu/event_notifier.h, qemu/notify.h,
qemu/processor.h, qemu/qsp.h, qemu/queue.h, qemu/thread-posix.h,
qemu/thread.h, qemu/timer.h, and a few more.
Include qemu/main-loop.h only where it's needed. Touching it now
recompiles only some 1700 objects. For block/aio.h and
qemu/event_notifier.h, these numbers drop from 5600 to 2800. For the
others, they shrink only slightly.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20190812052359.30071-21-armbru@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Diffstat (limited to 'hw/block')
| -rw-r--r-- | hw/block/dataplane/virtio-blk.c | 1 | ||||
| -rw-r--r-- | hw/block/dataplane/xen-block.c | 1 | ||||
| -rw-r--r-- | hw/block/fdc.c | 1 | ||||
| -rw-r--r-- | hw/block/xen-block.c | 1 |
4 files changed, 4 insertions, 0 deletions
diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c index 158c78f852..9299a1a7c2 100644 --- a/hw/block/dataplane/virtio-blk.c +++ b/hw/block/dataplane/virtio-blk.c @@ -16,6 +16,7 @@ #include "qapi/error.h" #include "trace.h" #include "qemu/iov.h" +#include "qemu/main-loop.h" #include "qemu/thread.h" #include "qemu/error-report.h" #include "hw/virtio/virtio-access.h" diff --git a/hw/block/dataplane/xen-block.c b/hw/block/dataplane/xen-block.c index 71c63330ac..3b9caeb2fa 100644 --- a/hw/block/dataplane/xen-block.c +++ b/hw/block/dataplane/xen-block.c @@ -20,6 +20,7 @@ #include "qemu/osdep.h" #include "qemu/error-report.h" +#include "qemu/main-loop.h" #include "qapi/error.h" #include "hw/xen/xen_common.h" #include "hw/block/xen_blkif.h" diff --git a/hw/block/fdc.c b/hw/block/fdc.c index 7542c8f273..e80439482c 100644 --- a/hw/block/fdc.c +++ b/hw/block/fdc.c @@ -41,6 +41,7 @@ #include "sysemu/blockdev.h" #include "sysemu/sysemu.h" #include "qemu/log.h" +#include "qemu/main-loop.h" #include "qemu/module.h" #include "trace.h" diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c index 848a0ad0ea..aef39536ac 100644 --- a/hw/block/xen-block.c +++ b/hw/block/xen-block.c @@ -7,6 +7,7 @@ #include "qemu/osdep.h" #include "qemu/cutils.h" +#include "qemu/main-loop.h" #include "qemu/module.h" #include "qemu/option.h" #include "qapi/error.h" |