diff options
| author | Emanuele Giuseppe Esposito <eesposit@redhat.com> | 2021-06-24 09:20:41 +0200 |
|---|---|---|
| committer | Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | 2021-06-25 14:33:35 +0300 |
| commit | e3dd339feec2da3bcd82021e4ce4fe09dbf9c8b4 (patch) | |
| tree | f50edcf5ed9c40d56b2eb45107149f5df7ef69ee /block/block-copy.c | |
| parent | 05d5e12b243df43a8a58568edf6a342806879d98 (diff) | |
| download | qemu-e3dd339feec2da3bcd82021e4ce4fe09dbf9c8b4.zip | |
block-copy: move progress_set_remaining in block_copy_task_end
Moving this function in task_end ensures to update the progress
anyways, even if there is an error.
It also helps in next patch, allowing task_end to have only
one critical section.
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Message-Id: <20210624072043.180494-4-eesposit@redhat.com>
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Diffstat (limited to 'block/block-copy.c')
| -rw-r--r-- | block/block-copy.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/block/block-copy.c b/block/block-copy.c index 0a1cf3d0cb..b7bcb9da86 100644 --- a/block/block-copy.c +++ b/block/block-copy.c @@ -248,6 +248,9 @@ static void coroutine_fn block_copy_task_end(BlockCopyTask *task, int ret) bdrv_set_dirty_bitmap(task->s->copy_bitmap, task->offset, task->bytes); } QLIST_REMOVE(task, list); + progress_set_remaining(task->s->progress, + bdrv_get_dirty_count(task->s->copy_bitmap) + + task->s->in_flight_bytes); qemu_co_queue_restart_all(&task->wait_queue); } @@ -638,9 +641,6 @@ block_copy_dirty_clusters(BlockCopyCallState *call_state) } if (s->skip_unallocated && !(ret & BDRV_BLOCK_ALLOCATED)) { block_copy_task_end(task, 0); - progress_set_remaining(s->progress, - bdrv_get_dirty_count(s->copy_bitmap) + - s->in_flight_bytes); trace_block_copy_skip_range(s, task->offset, task->bytes); offset = task_end(task); bytes = end - offset; |