diff options
author | Markus Armbruster <armbru@redhat.com> | 2019-03-13 09:43:30 +0100 |
---|---|---|
committer | Kevin Wolf <kwolf@redhat.com> | 2019-03-19 15:49:29 +0100 |
commit | e60483f2f8498ae08ae79ca4c6fb03a3317f5e1e (patch) | |
tree | 9e12f1adc1cf1b685e51ac0e33e19d082d7250f3 | |
parent | 9cd97956cfdde85d5887f2ea54ff598f615ee1b1 (diff) | |
download | qemu-e60483f2f8498ae08ae79ca4c6fb03a3317f5e1e.zip |
vl: Fix to create migration object before block backends again
Recent commit cda4aa9a5a0 moved block backend creation before machine
property evaluation. This broke qemu-iotests 055. Turns out we need
to create the migration object before block backends, so block
backends can add migration blockers. Fix by calling
migration_object_init() earlier, right before configure_blockdev().
Fixes: cda4aa9a5a08777cf13e164c0543bd4888b8adce
Reported-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
-rw-r--r-- | vl.c | 15 |
1 files changed, 8 insertions, 7 deletions
@@ -4277,9 +4277,16 @@ int main(int argc, char **argv, char **envp) } /* + * Migration object can only be created after global properties + * are applied correctly. + */ + migration_object_init(); + + /* * Note: we need to create block backends before * machine_set_property(), so machine properties can refer to - * them. + * them, and after migration_object_init(), so we can create + * migration blockers. */ configure_blockdev(&bdo_queue, machine_class, snapshot); @@ -4297,12 +4304,6 @@ int main(int argc, char **argv, char **envp) machine_class->name, machine_class->deprecation_reason); } - /* - * Migration object can only be created after global properties - * are applied correctly. - */ - migration_object_init(); - if (qtest_chrdev) { qtest_init(qtest_chrdev, qtest_log, &error_fatal); } |