diff options
author | Philippe Mathieu-Daudé <philmd@redhat.com> | 2019-03-09 19:19:19 +0100 |
---|---|---|
committer | Laurent Vivier <laurent@vivier.eu> | 2019-03-11 18:48:20 +0100 |
commit | 945309260d79de0df98c47ca078447a76fd70ec6 (patch) | |
tree | ad3810d4d2d9f0b2200959f83806a99ff1608343 | |
parent | 4a90846d6f61065140ff4c610bee6b4e385372f0 (diff) | |
download | qemu-945309260d79de0df98c47ca078447a76fd70ec6.zip |
hw/arm/virt: Remove null-check in virt_build_smbios()
Since commit 578f3c7b0835 ("arm: add fw_cfg to "virt" board",
2014-12-22), the machvirt_init() unconditionally creates the
fw_cfg object. Later, commit c30e15658b1b ("smbios: implement
smbios support for mach-virt", 2015-09-07) added a superfluous
null-check on it.
Remove this superfluous check.
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20190309181920.30553-2-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
-rw-r--r-- | hw/arm/virt.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 7f66ddad89..377e95a4cd 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -1281,10 +1281,6 @@ static void virt_build_smbios(VirtMachineState *vms) size_t smbios_tables_len, smbios_anchor_len; const char *product = "QEMU Virtual Machine"; - if (!vms->fw_cfg) { - return; - } - if (kvm_enabled()) { product = "KVM Virtual Machine"; } |