diff options
| author | Markus Armbruster <armbru@redhat.com> | 2010-01-29 19:48:59 +0100 |
|---|---|---|
| committer | Anthony Liguori <aliguori@us.ibm.com> | 2010-02-03 12:39:01 -0600 |
| commit | 5137b6accdbb43913c31e4d8579da4eb9957b0e7 (patch) | |
| tree | 3bebd65ab90ad94d7195743b4f3d07b1c486d636 | |
| parent | eecbb9fe6f9a9cffd8d305f688b1be27d197a253 (diff) | |
| download | qemu-5137b6accdbb43913c31e4d8579da4eb9957b0e7.zip | |
Revert "qdev: Add help for device properties"
This reverts commit 2ba6edf0dd740166632df80caa85992b20791a68.
The commit has two issues:
* When it runs from the monitor, e.g. "device_add e1000,?", it prints
to stderr instead of the monitor.
* Help looks to callers just like failed device creation. This makes
main() exit unsuccessfully on "-device e1000,?".
We need to do this differently.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
| -rw-r--r-- | hw/qdev-properties.c | 15 |
1 files changed, 2 insertions, 13 deletions
diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index 8547ad27d4..277ff9e780 100644 --- a/hw/qdev-properties.c +++ b/hw/qdev-properties.c @@ -544,19 +544,8 @@ int qdev_prop_parse(DeviceState *dev, const char *name, const char *value) prop = qdev_prop_find(dev, name); if (!prop) { - if (strcmp(name, "?") != 0) { - fprintf(stderr, "property \"%s.%s\" not found\n", - dev->info->name, name); - } else { - fprintf(stderr, "supported properties:\n"); - if (dev->info->props != NULL) { - Property *props = dev->info->props; - while (props->name) { - fprintf(stderr, "%s.%s\n", dev->info->name, props->name); - props++; - } - } - } + fprintf(stderr, "property \"%s.%s\" not found\n", + dev->info->name, name); return -1; } if (!prop->info->parse) { |