From 5db58be1bfa1393dbf087d972465b61b3d6baa31 Mon Sep 17 00:00:00 2001 From: Marcus Stollsteimer Date: Sat, 2 Dec 2017 14:32:29 +0100 Subject: Convert fallback option to a keyword argument Converting the optional fallback argument to a keyword argument fixes a problem that is caused by mixing optional arguments and optional keyword arguments. Without this change, a hash as fallback value is not handled correctly: in Psych.load("", nil, {}) the hash is not interpreted as the fallback value, and the default value for the fallback argument is used instead. --- test/psych/test_psych.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'test') diff --git a/test/psych/test_psych.rb b/test/psych/test_psych.rb index 82906f0..2812fd1 100644 --- a/test/psych/test_psych.rb +++ b/test/psych/test_psych.rb @@ -146,7 +146,7 @@ class TestPsych < Psych::TestCase def test_load_file_with_fallback Tempfile.create(['empty', 'yml']) {|t| - assert_equal Hash.new, Psych.load_file(t.path, Hash.new) + assert_equal Hash.new, Psych.load_file(t.path, fallback: Hash.new) } end -- cgit v1.2.3