Age | Commit message (Collapse) | Author |
|
1409: unistd: Increase maximum passwd/group buffer to 1MB r=asomers a=geofft
We have one UNIX group that contains most of our users whose size is
about 20 kB, so `Group::from_name` is failing with ERANGE.
The discussion on PR #864 suggests that 1 MB is a reasonable maximum -
it follows what FreeBSD's libc does. (glibc appears to have no maximum
on the _r function and will just double the buffer until malloc fails,
but that's not particularly Rusty.)
Co-authored-by: Geoffrey Thomas <geofft@twosigma.com>
|
|
We have one UNIX group that contains most of our users whose size is
about 20 kB, so `Group::from_name` is failing with ERANGE.
The discussion on PR #864 suggests that 1 MB is a reasonable maximum -
it follows what FreeBSD's libc does. (glibc appears to have no maximum
on the _r function and will just double the buffer until malloc fails,
but that's not particularly Rusty.)
|
|
1401: cleanup: remove redundant unwrap in Dir::from_fd r=asomers a=scottlamb
Co-authored-by: Scott Lamb <slamb@slamb.org>
|
|
1406: Allow cmsg_space! to be used in unit tests r=asomers a=WiSaGaN
Fixes https://github.com/nix-rust/nix/issues/1405
Co-authored-by: Lu, Wangshan <wisagan@gmail.com>
|
|
1407: Fix test_vsock failure on VMADDR_CID_LOCAL testing and re-enable it r=asomers a=stefano-garzarella
Starting from Linux 5.6, `VMADDR_CID_LOCAL` is supported to do local communication (loopback device).
Before Linux 5.6 it was called `VMADDR_CID_RESERVED` and was not supported, so we could expect an `EADDRNOTAVAIL`, but now this address is supported and handled by the 'vsock_loopback' kernel module loaded automatically if no other vsock transports are loaded.
Issue #1310
Issue #1403
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Co-authored-by: Stefano Garzarella <sgarzare@redhat.com>
|
|
|
|
This reverts commit c0783e7f8d55a7725179afc1b3c8eeae932d228c.
Now the test should work correctly, so we can re-enable it.
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
|
|
Starting from Linux 5.6, VMADDR_CID_LOCAL is supported to do local
communication (loopback device).
Before Linux 5.6 it was called VMADDR_CID_RESERVED and was not
supported, so we could expect an EADDRNOTAVAIL, but now this address
is supported and handled by the 'vsock_loopback' kernel module loaded
automatically if no other vsock transports are loaded.
Issue #1310
Issue #1403
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
|
|
1394: illumos and Solaris support r=asomers a=jasonbking
Adds support for the illumos target as well as improvements in the existing Solaris support.
Co-authored-by: Dominik Hassler <hadfl@omnios.org>
Co-authored-by: Joshua M. Clulow <josh@sysmgr.org>
Co-authored-by: Jason King <jason.brian.king@gmail.com>
|
|
|
|
Co-authored-by: Dominik Hassler <hadfl@omnios.org>
Co-authored-by: Joshua M. Clulow <josh@sysmgr.org>
|
|
1404: Temporarily disable test_vsock on QEMU arches r=asomers a=asomers
Issue #1403
Co-authored-by: Alan Somers <asomers@gmail.com>
|
|
Issue #1403
|
|
1395: Allow sockaddr_ll size mismatch r=asomers a=internetionals
Apparently the Linux kernel can return smaller sizes when the value in
the last element of sockaddr_ll (`sll_addr`) is smaller than the
declared size of that field.
Co-authored-by: Justin Ossevoort <github@internetionals.nl>
|
|
Apparently the Linux kernel can return smaller sizes when the value in
the last element of sockaddr_ll (`sll_addr`) is smaller than the
declared size of that field.
|
|
Remove a duplicate stanza from .cirrus.yml
|
|
|
|
Remove accept4 on Android arm
|
|
libc removed it in version 0.2.87.
https://github.com/rust-lang/libc/pull/2079
|
|
During CI, use just 1 cpu for QEMU builds
|
|
https://github.com/cirruslabs/cirrus-ci-docs/issues/741
|
|
1390: pty: Make forkpty() unsafe r=asomers a=tavianator
After the child returns from a fork() of a multi-threaded process, it is
undefined behaviour to call non-async-signal-safe functions according to
POSIX. Since forkpty() is implemented in terms of fork(), those
restrictions should apply to it too.
Fixes #1388
Co-authored-by: Tavian Barnes <tavianator@tavianator.com>
|
|
Various maintenance stuff
|
|
After the child returns from a fork() of a multi-threaded process, it is
undefined behaviour to call non-async-signal-safe functions according to
POSIX. Since forkpty() is implemented in terms of fork(), those
restrictions should apply to it too.
|
|
This eliminates some duplicate dependencies
|
|
This eliminates the need to build multiple versions of cfg-if
|
|
|
|
|
|
Prepare for release 0.20.0
|
|
|
|
|
|
1381: Close file descriptor on drop in TimerFd r=asomers a=crdumoul
This change closes the TimerFd file descriptor on drop. Note that the TimerFd will no longer be `Clone` or `Copy`. Since it has a destructor it can't be `Copy`, and if it were `Clone` you could end up trying to use a closed TimerFd, or double-closing the file descriptor.
Addresses #1379.
Co-authored-by: Christopher Dumoulin <cdumouli@akamai.com>
Co-authored-by: Alan Somers <asomers@gmail.com>
|
|
|
|
1366: x32 port r=asomers a=nabijaczleweli
I played pretty loose with the statfs bit, hoping for CI to tell me if I broke something.
Co-authored-by: наб <nabijaczleweli@nabijaczleweli.xyz>
|
|
|
|
|
|
|
|
Based on
https://github.com/nix-rust/nix/issues/1384#issuecomment-774708486
|
|
|
|
|
|
|
|
Test fix obtained from
https://github.com/nix-rust/nix/issues/1384#issuecomment-774708486
|
|
1333: Dir: Implement `IntoIterator` for `Dir` r=asomers a=wmanley
This is useful to allow returning an iterator based on a directory iterator
without needing a self-referential struct.
Co-authored-by: William Manley <will@stb-tester.com>
|
|
This is useful to allow returning an iterator based on a directory iterator
without needing a self-referential struct.
|
|
1387: fix(unsafe): remove unnecessary unsafe r=asomers a=matu3ba
libc 0.2.82 exposes status signals with macros generating safe functions
Co-authored-by: Jan Philipp Hafer <jan.hafer@rwth-aachen.de>
|
|
closes #1380
libc 0.2.82 exposes status signals with macros generating safe functions
|
|
|
|
1382: Don't implement Clone on Dir, SignalFd, and PtyMaster r=asomers a=asomers
Since they close their file descriptors on Drop, it's almost impossible
to use Clone without creating a double-close situation.
Also, check for EBADF in SignalFd::drop and Dir::drop.
Co-authored-by: Alan Somers <asomers@gmail.com>
|
|
Since they close their file descriptors on Drop, it's almost impossible
to use Clone without creating a double-close situation.
Also, check for EBADF in SignalFd::drop and Dir::drop.
|
|
1338: Add a passwd field to Group r=asomers a=blinsay
Adds a `passwd` field to unistd::Group. The `gr_passwd` field exists on `libc::group` and wasn't exposed.
I didn't see tests for `from(libc:group)` for either `User` or `Password`. Let me know if there are other tests I should add!
Co-authored-by: Ben Linsay <blinsay@gmail.com>
|