summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorNelson Chen <crazysim@gmail.com>2017-08-24 00:47:20 -0700
committerNelson Chen <crazysim@gmail.com>2017-08-24 10:40:07 -0700
commit505bed350d37811c1ed52302f4b820711a57041f (patch)
treecfe0af2bc6cbbd18242870f32f558dd9db95a6e2 /test
parentb76cbeea39a1e11872e9316711ac093dc99ad91d (diff)
downloadnix-505bed350d37811c1ed52302f4b820711a57041f.zip
Mark and document pty::ptsname() as unsafe
`ptsname()` mutates global variables and mutating global variables is always considered `unsafe` by Rust. Reference: https://github.com/nix-rust/nix/pull/742#issuecomment-324385919
Diffstat (limited to 'test')
-rw-r--r--test/test_pty.rs12
1 files changed, 6 insertions, 6 deletions
diff --git a/test/test_pty.rs b/test/test_pty.rs
index 75ef4923..89706f0c 100644
--- a/test/test_pty.rs
+++ b/test/test_pty.rs
@@ -35,7 +35,7 @@ fn test_ptsname_equivalence() {
assert!(master_fd.as_raw_fd() > 0);
// Get the name of the slave
- let slave_name = ptsname(&master_fd).unwrap();
+ let slave_name = unsafe { ptsname(&master_fd) }.unwrap() ;
let slave_name_r = ptsname_r(&master_fd).unwrap();
assert_eq!(slave_name, slave_name_r);
}
@@ -53,8 +53,8 @@ fn test_ptsname_copy() {
assert!(master_fd.as_raw_fd() > 0);
// Get the name of the slave
- let slave_name1 = ptsname(&master_fd).unwrap();
- let slave_name2 = ptsname(&master_fd).unwrap();
+ let slave_name1 = unsafe { ptsname(&master_fd) }.unwrap();
+ let slave_name2 = unsafe { ptsname(&master_fd) }.unwrap();
assert!(slave_name1 == slave_name2);
// Also make sure that the string was actually copied and they point to different parts of
// memory.
@@ -92,8 +92,8 @@ fn test_ptsname_unique() {
assert!(master2_fd.as_raw_fd() > 0);
// Get the name of the slave
- let slave_name1 = ptsname(&master1_fd).unwrap();
- let slave_name2 = ptsname(&master2_fd).unwrap();
+ let slave_name1 = unsafe { ptsname(&master1_fd) }.unwrap();
+ let slave_name2 = unsafe { ptsname(&master2_fd) }.unwrap();
assert!(slave_name1 != slave_name2);
}
@@ -116,7 +116,7 @@ fn test_open_ptty_pair() {
unlockpt(&master_fd).expect("unlockpt failed");
// Get the name of the slave
- let slave_name = ptsname(&master_fd).expect("ptsname failed");
+ let slave_name = unsafe { ptsname(&master_fd) }.expect("ptsname failed");
// Open the slave device
let slave_fd = open(Path::new(&slave_name), O_RDWR, stat::Mode::empty()).unwrap();