summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorScott Lamb <slamb@slamb.org>2021-03-16 10:47:18 -0700
committerScott Lamb <slamb@slamb.org>2021-03-21 16:23:43 -0700
commit49ed986b79e530a1f5e424a04ce732e70077507f (patch)
tree1682fc089f87622628be6981fcca52777923b14c /src
parent7b3129a194ecbf3e5f99f30ff26ab0e6fa7f183d (diff)
downloadnix-49ed986b79e530a1f5e424a04ce732e70077507f.zip
cleanup: remove redundant unwrap in Dir::from_fd
Diffstat (limited to 'src')
-rw-r--r--src/dir.rs10
1 files changed, 4 insertions, 6 deletions
diff --git a/src/dir.rs b/src/dir.rs
index 7d4ab82f..e3f0098e 100644
--- a/src/dir.rs
+++ b/src/dir.rs
@@ -53,14 +53,12 @@ impl Dir {
/// Converts from a file descriptor, closing it on success or failure.
pub fn from_fd(fd: RawFd) -> Result<Self> {
- let d = unsafe { libc::fdopendir(fd) };
- if d.is_null() {
+ let d = ptr::NonNull::new(unsafe { libc::fdopendir(fd) }).ok_or_else(|| {
let e = Error::last();
unsafe { libc::close(fd) };
- return Err(e);
- };
- // Always guaranteed to be non-null by the previous check
- Ok(Dir(ptr::NonNull::new(d).unwrap()))
+ e
+ })?;
+ Ok(Dir(d))
}
/// Returns an iterator of `Result<Entry>` which rewinds when finished.