diff options
author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2020-08-22 19:38:56 +0000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-08-22 19:38:56 +0000 |
commit | 8ab88ee1366e11ac7978c31f75e92c95f9b7cf14 (patch) | |
tree | 16fb65c1f7e69af556a8aeaed80db2deaed48cb7 /RELEASE_PROCEDURE.md | |
parent | 99f5c5b957c93fb093b431538f230fcb93d93f7b (diff) | |
parent | 28d6e0c9a17f6b4f4b73bc58767185d39d7cd05e (diff) | |
download | nix-8ab88ee1366e11ac7978c31f75e92c95f9b7cf14.zip |
Merge #1278
1278: Allow both &[CString] and &[&CStr] for sequence args in unistd r=asomers a=youknowone
I am new to this project, so I wonder this kind of change is acceptable for the project or not.
I agree taking `&[&CStr]` is the ideal way for the functions. But unfortunately, when users generate `CString`s from `&str`, they may get `&[CString]` rather than `&[&CStr]`
Unlike single `CString` to `&CStr` argument, there is no easy way to convert `&[CString]` to `&[&CStr]` without creating new vector.
By changing the type from `&[&CStr]` to `&[AsRef<CStr>]`, the args now can take both `&[CString]` and `&[&CStr]` without changing that much from nix.
Co-authored-by: Jeong YunWon <jeong@youknowone.org>
Diffstat (limited to 'RELEASE_PROCEDURE.md')
0 files changed, 0 insertions, 0 deletions