summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTyler Miller <tmillr@proton.me>2024-07-28 17:49:10 -0700
committer最萌小汐 <sumneko@hotmail.com>2024-08-01 16:53:47 +0800
commitd0a712ddab9e0ecb9569870d2a26a6ce95d3e305 (patch)
treeb95590aa65f8a81a62bab8bca22e30c9fa06a22f
parent1c7755b317d1e811a3f71f3ec745800555575fd0 (diff)
downloadlua-language-server-d0a712ddab9e0ecb9569870d2a26a6ce95d3e305.zip
fix: incorrect `CompletionItemKind` for postfix snippets
-rw-r--r--changelog.md1
-rw-r--r--script/core/completion/postfix.lua2
-rw-r--r--test/completion/common.lua26
3 files changed, 15 insertions, 14 deletions
diff --git a/changelog.md b/changelog.md
index fadf1296..98d4e662 100644
--- a/changelog.md
+++ b/changelog.md
@@ -15,6 +15,7 @@
* `FIX` Inconsistent type narrow behavior of function call args [#2758](https://github.com/LuaLS/lua-language-server/issues/2758)
* `FIX` Typos in annotation descriptions
* `NEW` You can now click on "References" in CodeLen to display the reference list
+* `FIX` incorrect `CompletionItemKind` for postfix snippets [#2773](https://github.com/LuaLS/lua-language-server/pull/2773)
## 3.9.3
`2024-6-11`
diff --git a/script/core/completion/postfix.lua b/script/core/completion/postfix.lua
index b5f33315..46c24b8e 100644
--- a/script/core/completion/postfix.lua
+++ b/script/core/completion/postfix.lua
@@ -353,7 +353,7 @@ local function checkPostFix(state, word, wordPosition, position, symbol, results
end):gsub('%$%{?%d+%}?', '')
results[#results+1] = {
label = action.key,
- kind = define.CompletionItemKind.Event,
+ kind = define.CompletionItemKind.Snippet,
description = markdown()
: add('lua', descText)
: string(),
diff --git a/test/completion/common.lua b/test/completion/common.lua
index ec2372a0..30350642 100644
--- a/test/completion/common.lua
+++ b/test/completion/common.lua
@@ -3235,7 +3235,7 @@ xx@pcall<??>
{
[1] = {
label = 'pcall',
- kind = define.CompletionItemKind.Event,
+ kind = define.CompletionItemKind.Snippet,
textEdit = {
start = 3,
finish = 8,
@@ -3257,7 +3257,7 @@ xx()@pcall<??>
{
[1] = {
label = 'pcall',
- kind = define.CompletionItemKind.Event,
+ kind = define.CompletionItemKind.Snippet,
textEdit = {
start = 5,
finish = 10,
@@ -3279,7 +3279,7 @@ xx(1, 2, 3)@pcall<??>
{
[1] = {
label = 'pcall',
- kind = define.CompletionItemKind.Event,
+ kind = define.CompletionItemKind.Snippet,
textEdit = {
start = 12,
finish = 17,
@@ -3301,7 +3301,7 @@ xx@xpcall<??>
{
[1] = {
label = 'xpcall',
- kind = define.CompletionItemKind.Event,
+ kind = define.CompletionItemKind.Snippet,
textEdit = {
start = 3,
finish = 9,
@@ -3323,7 +3323,7 @@ xx()@xpcall<??>
{
[1] = {
label = 'xpcall',
- kind = define.CompletionItemKind.Event,
+ kind = define.CompletionItemKind.Snippet,
textEdit = {
start = 5,
finish = 11,
@@ -3345,7 +3345,7 @@ xx(1, 2, 3)@xpcall<??>
{
[1] = {
label = 'xpcall',
- kind = define.CompletionItemKind.Event,
+ kind = define.CompletionItemKind.Snippet,
textEdit = {
start = 12,
finish = 18,
@@ -3367,7 +3367,7 @@ xx@function<??>
{
[1] = {
label = 'function',
- kind = define.CompletionItemKind.Event,
+ kind = define.CompletionItemKind.Snippet,
textEdit = {
start = 3,
finish = 11,
@@ -3389,7 +3389,7 @@ xx.yy@method<??>
{
[1] = {
label = 'method',
- kind = define.CompletionItemKind.Event,
+ kind = define.CompletionItemKind.Snippet,
textEdit = {
start = 6,
finish = 12,
@@ -3411,7 +3411,7 @@ xx:yy@method<??>
{
[1] = {
label = 'method',
- kind = define.CompletionItemKind.Event,
+ kind = define.CompletionItemKind.Snippet,
textEdit = {
start = 6,
finish = 12,
@@ -3433,7 +3433,7 @@ xx@insert<??>
{
[1] = {
label = 'insert',
- kind = define.CompletionItemKind.Event,
+ kind = define.CompletionItemKind.Snippet,
textEdit = {
start = 3,
finish = 9,
@@ -3455,7 +3455,7 @@ xx++<??>
{
[1] = {
label = '++',
- kind = define.CompletionItemKind.Event,
+ kind = define.CompletionItemKind.Snippet,
textEdit = {
start = 2,
finish = 4,
@@ -3471,7 +3471,7 @@ xx++<??>
},
[2] = {
label = '++?',
- kind = define.CompletionItemKind.Event,
+ kind = define.CompletionItemKind.Snippet,
textEdit = {
start = 2,
finish = 4,
@@ -3495,7 +3495,7 @@ end)
{
[1] = {
label = 'xpcall',
- kind = define.CompletionItemKind.Event,
+ kind = define.CompletionItemKind.Snippet,
textEdit = {
start = 10007,
finish = 10013,