summaryrefslogtreecommitdiff
path: root/src/irc/core
AgeCommit message (Collapse)Author
2018-01-07Merge pull request #804 from ailin-nemui/patch-1ailin-nemui
handle an already used nick different from the one we send
2018-01-05Update irc-nicklist.cailin-nemui
move altnick check before the nick correction code
2018-01-03do not record topic change time when sender is blankailin-nemui
2017-12-11Merge pull request #766 from horgh/horgh/mode-parsingailin-nemui
Fix MODE parameter parsing
2017-12-02Update NULL comparison style and be C89 compatibleWill Storey
2017-11-30fix commentsailin-nemui
2017-11-27Revert initializing pointers to NULLWill Storey
To maintain C89 compatibility
2017-11-10use enumailin-nemui
2017-11-01show initial nick and name on first startailin-nemui
2017-10-24Strip : from <trailing> parametersWill Storey
This is to fix #601. The function used to extract the mode string assumed that ":" would only occur in a particular spot. This lead to the possibility that ":" could be treated as part of things like nicknames or mode arguments, where it should have been stripped as part of protocol escaping.
2017-10-20Merge branch 'fix-16' into 'security'Nei
Prevent a OOB read when parsing IRCNet ! channels See merge request irssi/irssi!22
2017-10-20Merge branch 'fix-gl-15' into 'security'Nei
Don't proceed with cmd_msg if there was an error splitting msg See merge request irssi/irssi!21
2017-10-20Make split functions return an array with NULL instead of NULLJoseph Bisch
This avoids undefined behavior in functions that call these split functions and expect an array back instead of just a NULL pointer.
2017-10-20Merge branch 'fix-gl-13' into 'security'Nei
Fix use after free when channel is destroyed inbetween being synced See merge request irssi/irssi!19
2017-10-19Prevent a OOB read when parsing IRCNet ! channelsLemonBoy
Make sure the string has enough data. Fixes #16
2017-10-14Changes based on comments in pull #771.Paul Townsend
2017-10-11Add alternate_nick as a network-specific property.Paul Townsend
2017-10-08Fix segfault in query_remove_allJoseph Bisch
It is possible for rec to be NULL in query_remove_all, resulting in a segfault. So return without doing anything if rec is NULL.
2017-10-08fix uaf in chanquery moduleailin-nemui
the chanquery needs to be removed in any case if a channel rec is destroyed, regardless of any state Fixes GL#13
2017-07-25Allow the user to clear the sasl-related fieldsLemonBoy
There was no easy way for the user to disable the SASL authentication or to clear the username/password once the network was created. Closes #718
2017-01-24Prevent a memory leak during the processing of the SASL response.LemonBoy
We also get rid of an allocation in the process of doing so.
2017-01-10Revert "Don't reset wait_cmd during connection registration (fixes early ISON)"dx
2017-01-08Merge pull request #608 from tijko/masterLemonBoy
Follow g_strsplit with call to g_strfreev
2017-01-07Follow g_strsplit with call to g_strfreevTim Konick
2017-01-06Don't reset wait_cmd during connection registration (fixes early ISON)dequis
2017-01-03Merge branch 'master' into 'security'Nei
Sync to master See merge request !6
2017-01-02Merge branch '4-use-after-free-when-receiving-numeric-432-invalid-nick' into ↵Nei
'security' avoid server_disconnect See merge request !4
2017-01-02Merge pull request #586 from LemonBoy/fix-580ailin-nemui
Process the nick changes in queries before the PRIVMSG is handled.
2016-12-19bail out if nick is NULL in irc_query_findailin-nemui
Closes #1
2016-12-19avoid server_disconnectailin-nemui
Closes #4
2016-12-15Process the nick changes in queries before the PRIVMSG is handled.LemonBoy
Otherwise we end up with the message in the status window since the frontend knows jack shit about the casemapping option when it tries to find the associated window for the query.
2016-12-12Add an option to stop the connection when SASL fails.LemonBoy
2016-10-22Rename SSL to TLS.Alexander Færøy
This patch changes the internal name of SSL to TLS. We also add -tls_* options to /CONNECT and /SERVER, but make sure that the -ssl_* versions of the commands continue to work like before.
2016-09-30Make the cap_complete field unsigned.LemonBoy
Fixes a problem where the field would end up as a negative number when exposed to the perl scripts. And move it near the other bit-packed fields so we take advantage of the packing.
2016-09-26Merge pull request #506 from kruton/sasl-400-byte-chunkailin-nemui
SASL: handle fragmentation
2016-08-29SASL: handle fragmentationKenny Root
The IRCv3 SASL extension says that AUTHENTICATION payloads of exactly 400 bytes in length indicate that the message is fragmented and will continue in a subsequent message. Handle the reassembly and splitting of these messages so that we are compliant with the specification.
2016-08-24Set the default STATUSMSG to @ instead of @+ if it's missingdequis
This fixes two issues: - IRCNet doesn't have STATUSMSG, but it supports +channels, and including + in the default value meant processing those incorrectly - The "bahamut hack", for old servers that support but don't advertise STATUSMSG, didn't work since ischannel_func doesn't use the default. The choice of @ intentionally leaves out support for other STATUSMSG (for example, AzzurraNet's bahamut 1.4 fork seemed to support + and % in any order, contradicting the comment in the code). I think this is a decent tradeoff, given how those servers are uncommon and relying on +# or %# is even less common than @#. Fixes #531
2016-06-14Merge pull request #422 from LemonBoy/misc-cleanupailin-nemui
Clean up misc.c
2016-06-13Use ; as separator instead of ,LemonBoy
2016-06-12Make rejoin_channels_mode of type CHOICELemonBoy
2016-06-05Clean up some GTimeVal jugglingLemonBoy
2016-06-05Replace strocpy with g_strlcpyLemonBoy
The only difference was that the former returned 1 if the buffer was overflown, but the return value was never checked.
2016-06-01Correct the name of the emitted signal.LemonBoy
There's a typo in 'sasl_fail', the signal that's emitted should be 'server sasl failure' and not 'server sasl fail'.
2016-03-29Revert "Removed the obsolete SQUERY and SERVLIST commands"ailin-nemui
This reverts commit 4beebe3238dda96efd4c3a0a6f6002ad5afc96e7.
2016-03-20Merge pull request #442 from LemonBoy/fix-435ailin-nemui
Do not assume any default value for statusmsg.
2016-03-20Use 0 as a sentinel value for sasl_timeoutLemonBoy
If sasl_timeout is never initialized with a valid timeout id then calling /disconnect on the server calls g_source_remove() with 0 as tag, causing an harmless error message to be printed. Beside that, the sasl_timeout field is defined as a unsigned int. We can use 0 as sentiel since g_timeout_add returns tags that are always greater than zero.
2016-03-19Make ischannel_func return false for empty stringsLemonBoy
2016-03-17Do not assume any default value for statusmsg.LemonBoy
If the server didn't send it then just skip the check, the old value it defaulted to was possibly overlapping with the CHANTYPES leading to an incorrect behaviour. Fixes #435.
2016-03-11Remove sasl timeout source when the server disconnectsdequis
2016-03-08Fix SASL EXTERNAL authenticationMantas Mikulėnas
The "AUTHENTICATE" command is always required – it's part of the IRCv3 SASL framing. RFC 4422 only documents the Base64 payload.