| Age | Commit message (Collapse) | Author |
|---|
|
Enable UTF8 in GRegex
|
|
Escape nicks during nick completion when expand_escapes is enabled
|
|
Allow -port <num> or irc.host.tld <num> in /server add
|
|
|
|
Fixes #693
|
|
|
|
|
|
The warning itself:
>warning: comparison between pointer and zero character constant [-Wpointer-compare]
Harmless stuff as far as I can tell.
The fix adds a null check that probably isn't needed. The old code that
compared against '\0' worked a lot like a null check so it makes sense
to keep that, while also adding the intended check for empty string.
This was visible with "/dcc close send a" showing an empty filename.
The equivalent for get didn't show the filename in the format string.
|
|
|
|
|
|
|
|
- with non-unicode byte to Private Use Area A mapping
- move all ifdefs to iregex.h file only
|
|
Originally found by oss-fuzz (issue 525) in get_ansi_color using ubsan.
After a lot of analysis I'm 99% sure this isn't security relevant so
it's fine to handle this publicly.
The fix is mainly adding a function that does it right and use it
everywhere. This is harder than it seems because the strtol() family of
functions doesn't have the friendliest of interfaces.
Aside from get_ansi_color(), there were other pieces of code that used
the same (out*10+(*in-'0')) pattern, like the parse_size() and
parse_time_interval() functions, which are mostly used for settings.
Those are interesting cases, since they multiply the parsed number
(resulting in more overflows) and they write to a signed integer
parameter (which can accidentally make the uints negative without UB)
Thanks to Pascal Cuoq for enlightening me about the undefined behavior
of parse_size (and, in particular, the implementation-defined behavior
of one of the WIP versions of this commit, where something like signed
integer overflow happened, but it was legal). Also for writing
tis-interpreter, which is better than ubsan to verify these things.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Don't allow command history to wrap around
|
|
Allows syntax info to be picked up and displayed by help command.
Fixes #687
|
|
We are no longer using over_counter for any functional purpose, so
remove it.
|
|
This changes the behavior of the command history to avoid wrapping back
to the bottom once the top of the history is reached.
|
|
If text is being entered and then the user presses the up arrow
followed by the down arrow, the expected behavior is to return to the
text being entered. Prior to this commit that was not the case.
Fixes #462
|
|
Timeout feature for keys
|
|
fe-netjoin: remove irc servers on "server disconnected" signal
Closes #7
See merge request !10
|
|
make foreach send commands
|
|
|
|
Quote the filename when dcc requests are auto accepted.
|
|
Prevent some potential null-pointer deferences.
See merge request !9
|
|
|
|
|
|
Let's repurpose escape_string and make it more flexible by letting us
choose the characters to escape.
|
|
Similar to how vim behaves.
|
|
Spotted by our friend scan-build.
|
|
Minor cleanup in the highlighting signal.
|
|
There are some cases (such as fuzzing with fe-fuzz) where suppressing
printf output may be desirable.
|
|
fixes #609
|
|
Sync to master
See merge request !6
|
|
g_sequence backing for window list
|
|
|
|
fix %[
See merge request !5
|
|
Also, plugged a memory leak when retrieving the match position.
|
|
It was made redundant by the introduction of the pointer to the GRegex
structure.
Silence the compiler warning in textbuffer.c about preg being
initialized by setting it to NULL.
|
|
|
|
Process the nick changes in queries before the PRIVMSG is handled.
|
|
|
|
|
|
|
