summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-06-05Performance improvements for /lastlog -beforedequis
This avoids the use of g_list_find() to find if a match was already added to the list of results, by checking the last two added matches instead. Checking just the last match isn't enough because a NULL match is added as a separator (shown as -- in the UI)
2017-06-05Performance improvements for /lastlog with big result setsdequis
This applies to "/lastlog" with no filters (or with filters that don't filter a lot) and with large amounts of text in the scrollback. Test case: /exec seq 1 500000 /lastlog -file log.txt Thanks to morning for reporting this.
2017-06-05fe-dcc-(get|send): Fix some -Wpointer-compare with newer gccdequis
The warning itself: >warning: comparison between pointer and zero character constant [-Wpointer-compare] Harmless stuff as far as I can tell. The fix adds a null check that probably isn't needed. The old code that compared against '\0' worked a lot like a null check so it makes sense to keep that, while also adding the intended check for empty string. This was visible with "/dcc close send a" showing an empty filename. The equivalent for get didn't show the filename in the format string.
2017-06-05Merge remote-tracking branch 'gitlab/security'Ailin Nemui
2017-06-05get rid of new_textailin-nemui
2017-06-05Update iregex-gregex.cailin-nemui
add 2 comments about new_string
2017-06-05Update iregex-gregex.cailin-nemui
make helper functions static
2017-06-04Make backward compatible with ssl flagsJari Matilainen
2017-06-04abi upailin-nemui
2017-06-04change ternary operator to if/else statements, add default ssl port supportJari Matilainen
2017-06-04Refactor regex and implement UTF8 mode for GRegexailin-nemui
- with non-unicode byte to Private Use Area A mapping - move all ifdefs to iregex.h file only
2017-06-02Merge pull request #706 from dequis/parse-uintailin-nemui
Add parse_uint function to improve integer overflow handling
2017-06-02Merge pull request #713 from josephbisch/fix-fe-fuzz-linkdx
Use CXX for fe-fuzz linking
2017-06-01Use CXX for fe-fuzz linkingJoseph Bisch
2017-05-30Merge branch 'fix-gl9' into 'security'Nei
Fix dcc_request where addr is NULL See merge request !13
2017-05-30Merge branch 'fix-gl8' into 'security'Nei
Fix oob read of one byte in get_file_params_count See merge request !12
2017-05-30Merge pull request #711 from ailin-nemui/24bit-resetailin-nemui
do not reset true colour bit on colour reset
2017-05-29Fix dcc_request where addr is NULLJoseph Bisch
2017-05-29Fix oob read of one byte in get_file_params_count{,_resume}Joseph Bisch
We can use continue to handle cases such as: "ab<space><space>c"
2017-05-29Update list.inailin-nemui
Add a more detailed paragraph about service bots Fixes #699 I would like to add another paragraph about how freenode is broken and spits at you the whole list instead of empty list if you attempt to use network side filtering......
2017-05-27do not reset true colour bit on colour resetailin-nemui
fixes #710
2017-05-18Merge pull request #707 from mh-source/patch-1ailin-nemui
dcc.in: fixed typo 'resolved' -> 'resolves'
2017-05-18Add parse_uint function to improve integer overflow handlingdequis
Originally found by oss-fuzz (issue 525) in get_ansi_color using ubsan. After a lot of analysis I'm 99% sure this isn't security relevant so it's fine to handle this publicly. The fix is mainly adding a function that does it right and use it everywhere. This is harder than it seems because the strtol() family of functions doesn't have the friendliest of interfaces. Aside from get_ansi_color(), there were other pieces of code that used the same (out*10+(*in-'0')) pattern, like the parse_size() and parse_time_interval() functions, which are mostly used for settings. Those are interesting cases, since they multiply the parsed number (resulting in more overflows) and they write to a signed integer parameter (which can accidentally make the uints negative without UB) Thanks to Pascal Cuoq for enlightening me about the undefined behavior of parse_size (and, in particular, the implementation-defined behavior of one of the WIP versions of this commit, where something like signed integer overflow happened, but it was legal). Also for writing tis-interpreter, which is better than ubsan to verify these things.
2017-05-17dcc.in: fixed typo 'resolved' -&gt; 'resolves'mh
n/t
2017-05-15Make sure port is only set on /server modify if specifiedJari Matilainen
2017-05-14Merge pull request #702 from vague666/server_modify_notlsailin-nemui
Added support for -notls and -notls_verify
2017-05-14Update fe-server.cailin-nemui
2017-05-14Merge pull request #705 from ailin-nemui/nicklist-performanceailin-nemui
improve nicklist performance
2017-05-14Spaces to tabsJari Matilainen
2017-05-12expand macroailin-nemui
2017-05-12improve nicklist performanceailin-nemui
2017-05-11Added code commentsJari Matilainen
2017-05-11Allow -port <num> or irc.host.tld <port num> in /server add and /server modifyJari Matilainen
2017-05-11Added bracesJari Matilainen
2017-05-11Added support for -notls and -notls_verifyJari Matilainen
2017-05-08Merge pull request #701 from josephbisch/add-fuzz-patchJoseph Bisch
Add fuzz.diff for fuzzing with afl
2017-05-08Add fuzz.diff for fuzzing with aflJoseph Bisch
Authored by dx.
2017-05-04Merge pull request #698 from ailin-nemui/masterailin-nemui
detect Netbsd terminfo
2017-05-04detect Netbsd terminfoailin-nemui
fixes #694
2017-04-11Merge pull request #686 from josephbisch/remove-history-wrapLemonBoy
Don't allow command history to wrap around
2017-04-07Merge pull request #688 from josephbisch/fix-687ailin-nemui
Add syntax info for completion
2017-04-07Add syntax info for completionJoseph Bisch
Allows syntax info to be picked up and displayed by help command. Fixes #687
2017-04-07Remove over_counterJoseph Bisch
We are no longer using over_counter for any functional purpose, so remove it.
2017-04-06Don't allow command history to wrap aroundJoseph Bisch
This changes the behavior of the command history to avoid wrapping back to the bottom once the top of the history is reached.
2017-04-06Merge pull request #685 from josephbisch/fix-462ailin-nemui
Fix strange history behavior when history is empty
2017-04-05Fix strange history behavior when history is emptyJoseph Bisch
If text is being entered and then the user presses the up arrow followed by the down arrow, the expected behavior is to return to the text being entered. Prior to this commit that was not the case. Fixes #462
2017-04-04Merge pull request #677 from rrebello/openssl-miscailin-nemui
OpenSSL support detection and documentation fixes
2017-03-31Merge branch 'off-by-one-fix' into 'master' Joseph Bisch
Fix off by one error with char_expandos See merge request !11
2017-03-31Fix off by one error with char_expandosJoseph Bisch
2017-03-21Merge pull request #680 from Stevie-O/slow-startup-with-glib-2.49.3ailin-nemui
Fix slow startup with glib 2.49.3