From c551fe4c1eee7cc7a5c595f222190aac66fe6b78 Mon Sep 17 00:00:00 2001 From: Luiza Pagliari Date: Tue, 27 Oct 2015 07:44:51 -0200 Subject: Fix logic to check if any hook handled ACE key event. Fix #2818 Instead of checking if only the first hook had returned true, we check all hooks. --- src/static/js/ace2_inner.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/static/js/ace2_inner.js b/src/static/js/ace2_inner.js index d912dfb1..d746fc68 100644 --- a/src/static/js/ace2_inner.js +++ b/src/static/js/ace2_inner.js @@ -3715,7 +3715,12 @@ function Ace2Inner(){ documentAttributeManager: documentAttributeManager, evt:evt }); - specialHandled = (specialHandledInHook&&specialHandledInHook.length>0)?specialHandledInHook[0]:specialHandled; + + // if any hook returned true, set specialHandled with true + if (specialHandledInHook) { + specialHandled = _.contains(specialHandledInHook, true); + } + if ((!specialHandled) && altKey && isTypeForSpecialKey && keyCode == 120){ // Alt F9 focuses on the File Menu and/or editbar. // Note that while most editors use Alt F10 this is not desirable -- cgit v1.2.3