diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2022-10-12 19:41:52 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-10-12 19:41:52 +0000 |
| commit | b7d09442650d765562b25f9f27d654c2ef5e014a (patch) | |
| tree | d27f371a5197a3e2fc4e939e860e9cc0cd0832d8 | |
| parent | 1559374a19d33dbc8f20f71a924993ab82f27057 (diff) | |
| parent | 4fd831e4a88fdba14751c8a71ae45fc0eac92c66 (diff) | |
| parent | e1faf8860776f6ad2bac2f3b06e7160fe00da7df (diff) | |
| download | embassy-b7d09442650d765562b25f9f27d654c2ef5e014a.zip | |
Merge #984 #1006
984: rp pico async i2c implementation r=Dirbaio a=jsgf
This implements an interrupt-driven async i2c master. It is based on https://github.com/embassy-rs/embassy/pull/914, a bit of https://github.com/embassy-rs/embassy/pull/978 and `@ithinuel's` https://github.com/ithinuel/rp2040-async-i2c.git
This is still work-in-progress, and is currently untested.
1006: Removes some of the code duplication for UarteWithIdle r=Dirbaio a=huntc
This PR removes some of the code duplications for `UarteWithIdle` at the slight expense of requiring a split when using idle processing. As the nRF example illustrates though given the LoC removed, this expense seems worth the benefit in terms of maintenance, and the avoidance of copying over methods. My main motivation for this PR was actually due to the `event_endtx` method not having been copied across to the idle-related code.
Tested the uart_idle example on my nRF52840-dk, and from within my app. Both appear to work fine.
Co-authored-by: Jeremy Fitzhardinge <jeremy@goop.org>
Co-authored-by: huntc <huntchr@gmail.com>