From a32f6b008aafedd289a79947d08d304e9aaad57a Mon Sep 17 00:00:00 2001 From: Lukas Fleischer Date: Tue, 8 Jul 2014 13:24:25 +0200 Subject: Make sure that tmppath is always NULL-terminated Fixes GitHub issue #5. Reported-by: dcb314 Signed-off-by: Lukas Fleischer --- src/config.c | 4 ++-- src/note.c | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/config.c b/src/config.c index da6b049..5eb526a 100644 --- a/src/config.c +++ b/src/config.c @@ -600,8 +600,8 @@ unsigned config_save(void) return 1; strncpy(tmppath, get_tempdir(), BUFSIZ); - strncat(tmppath, "/" CONF_PATH_NAME ".", - BUFSIZ - strlen(tmppath) - 1); + tmppath[BUFSIZ - 1] = '\0'; + strncat(tmppath, "/" CONF_PATH_NAME ".", BUFSIZ - strlen(tmppath) - 1); if ((tmpext = new_tempfile(tmppath, TMPEXTSIZ)) == NULL) return 0; strncat(tmppath, tmpext, BUFSIZ - strlen(tmppath) - 1); diff --git a/src/note.c b/src/note.c index a6e48d7..9bce762 100644 --- a/src/note.c +++ b/src/note.c @@ -83,6 +83,7 @@ void edit_note(char **note, const char *editor) FILE *fp; strncpy(tmppath, get_tempdir(), BUFSIZ); + tmppath[BUFSIZ - 1] = '\0'; strncat(tmppath, "/calcurse-note.", BUFSIZ - strlen(tmppath) - 1); if ((tmpext = new_tempfile(tmppath, TMPEXTSIZ)) == NULL) return; -- cgit v1.2.3