Declare several parameters/variables constant

Add the "const" keyword to parameters and variables that are never
modified. Most of these were spotted by "-Wwrite-strings".

We cast the second parameter to execvp() explicitly as it expects a
"char *const[]" where it should expect a "const char *const[]"
(according to the documentation, this is due to compatibility reasons).
This should be changed once we come up with a better solution.

Signed-off-by: Lukas Fleischer <calcurse@cryptocrack.de>

1 files changed, 4 insertions, 4 deletions

diff --git a/src/note.c b/src/note.c
index a65a384..09b6d0d 100644
--- a/src/note.c
+++ b/src/note.c
@@ -46,7 +46,7 @@ struct note_gc_hash {
   HTABLE_ENTRY (note_gc_hash);
 };
 
-static void note_gc_extract_key (struct note_gc_hash *, char **, int *);
+static void note_gc_extract_key (struct note_gc_hash *, const char **, int *);
 static int note_gc_cmp (struct note_gc_hash *, struct note_gc_hash *);
 
 HTABLE_HEAD (htp, NOTE_GC_HSIZE, note_gc_hash);
@@ -74,7 +74,7 @@ generate_note (const char *str)
 
 /* Edit a note with an external editor. */
 void
-edit_note (char **note, char *editor)
+edit_note (char **note, const char *editor)
 {
   char tmppath[BUFSIZ];
   char *tmpext;
@@ -114,7 +114,7 @@ edit_note (char **note, char *editor)
 
 /* View a note in an external pager. */
 void
-view_note (char *note, char *pager)
+view_note (const char *note, const char *pager)
 {
   char fullname[BUFSIZ];
 
@@ -155,7 +155,7 @@ note_read (char *buffer, FILE *fp)
 }
 
 static void
-note_gc_extract_key (struct note_gc_hash *data, char **key, int *len)
+note_gc_extract_key (struct note_gc_hash *data, const char **key, int *len)
 {
   *key = data->hash;
   *len = strlen (data->hash);