From 912f632bf591377a69bf688f6a85668d93be8841 Mon Sep 17 00:00:00 2001
From: Nils Leuzinger <nilsl@student.ethz.ch>
Date: Thu, 5 Apr 2018 21:04:11 +0200
Subject: Add fsc linter for Scala (#1452)

* Add fsc as a Scala linter

* Pull reused code into `autoload/ale/` directory

* Include fsc into the README

* Add unit test for testing the scala handler

* Add unit test for scala's fsc linter

* Rename scala unit tests for clarity

* Fix typo in README

* Fix typos in doc/ale.txt

* Fix author headline

* Put methods for fsc commands back into fsc.vim

* Move command_callback tests to correct location

* Rewrite handler test so it actually tests handler

* Clarify description of test in test_scala_handler
---
 .../test_fsc_command_callback.vader                | 17 ++++++++++++
 .../test_scalac_command_callback.vader             | 17 ++++++++++++
 test/handler/test_scala_handler.vader              | 32 ++++++++++++++++++++++
 test/handler/test_scalac_handler.vader             | 18 ------------
 4 files changed, 66 insertions(+), 18 deletions(-)
 create mode 100644 test/command_callback/test_fsc_command_callback.vader
 create mode 100644 test/command_callback/test_scalac_command_callback.vader
 create mode 100644 test/handler/test_scala_handler.vader
 delete mode 100644 test/handler/test_scalac_handler.vader

(limited to 'test')

diff --git a/test/command_callback/test_fsc_command_callback.vader b/test/command_callback/test_fsc_command_callback.vader
new file mode 100644
index 00000000..451fa108
--- /dev/null
+++ b/test/command_callback/test_fsc_command_callback.vader
@@ -0,0 +1,17 @@
+Before:
+  runtime ale_linters/scala/fsc.vim
+
+After:
+  call ale#linter#Reset()
+
+Given scala(An empty Scala file):
+Execute(The default executable and command should be correct):
+  AssertEqual 'fsc', ale_linters#scala#fsc#GetExecutable(bufnr(''))
+  AssertEqual
+  \ ale#Escape('fsc') . ' -Ystop-after:parser %t',
+  \ ale_linters#scala#fsc#GetCommand(bufnr(''))
+
+Given scala.sbt(An empty SBT file):
+Execute(fsc should not be run for sbt files):
+  AssertEqual '', ale_linters#scala#fsc#GetExecutable(bufnr(''))
+  AssertEqual '', ale_linters#scala#fsc#GetCommand(bufnr(''))
diff --git a/test/command_callback/test_scalac_command_callback.vader b/test/command_callback/test_scalac_command_callback.vader
new file mode 100644
index 00000000..6bb31b3f
--- /dev/null
+++ b/test/command_callback/test_scalac_command_callback.vader
@@ -0,0 +1,17 @@
+Before:
+  runtime ale_linters/scala/scalac.vim
+
+After:
+  call ale#linter#Reset()
+
+Given scala(An empty Scala file):
+Execute(The default executable and command should be correct):
+  AssertEqual 'scalac', ale_linters#scala#scalac#GetExecutable(bufnr(''))
+  AssertEqual
+  \ ale#Escape('scalac') . ' -Ystop-after:parser %t',
+  \ ale_linters#scala#scalac#GetCommand(bufnr(''))
+
+Given scala.sbt(An empty SBT file):
+Execute(scalac should not be run for sbt files):
+  AssertEqual '', ale_linters#scala#scalac#GetExecutable(bufnr(''))
+  AssertEqual '', ale_linters#scala#scalac#GetCommand(bufnr(''))
diff --git a/test/handler/test_scala_handler.vader b/test/handler/test_scala_handler.vader
new file mode 100644
index 00000000..3214bdbc
--- /dev/null
+++ b/test/handler/test_scala_handler.vader
@@ -0,0 +1,32 @@
+After:
+  call ale#linter#Reset()
+
+Execute(The handler should return an empty list with empty input):
+  AssertEqual [], ale#handlers#scala#HandleScalacLintFormat(bufnr(''), [])
+
+Execute(The handler should correctly parse error messages):
+  AssertEqual 
+  \ [
+  \   { 
+  \     'lnum': 4,
+  \     'col':  8,
+  \     'text': ''':'' expected but identifier found.',
+  \     'type': 'E'
+  \   },
+  \   {
+  \     'lnum': 6,
+  \     'col':  2,
+  \     'text': 'identifier expected but eof found.',
+  \     'type': 'E'
+  \   }
+  \ ],
+  \ ale#handlers#scala#HandleScalacLintFormat(bufnr(''),
+  \ [
+  \ "hi.scala:4: error: ':' expected but identifier found.",
+  \ "  Some stupid scala code",
+  \ "       ^",
+  \ "hi.scala:6: error: identifier expected but eof found.",
+  \ ")",
+  \ " ^",
+  \ "two errors found",
+  \ ])
diff --git a/test/handler/test_scalac_handler.vader b/test/handler/test_scalac_handler.vader
deleted file mode 100644
index fd222f67..00000000
--- a/test/handler/test_scalac_handler.vader
+++ /dev/null
@@ -1,18 +0,0 @@
-Before:
-  runtime ale_linters/scala/scalac.vim
-
-After:
-  call ale#linter#Reset()
-
-Given scala(An empty Scala file):
-
-Execute(The default executable and command should be correct):
-  AssertEqual 'scalac', ale_linters#scala#scalac#GetExecutable(bufnr(''))
-  AssertEqual
-  \ ale#Escape('scalac') . ' -Ystop-after:parser %t',
-  \ ale_linters#scala#scalac#GetCommand(bufnr(''))
-
-Given scala.sbt(An empty SBT file):
-Execute(scalac should not be run for sbt files):
-  AssertEqual '', ale_linters#scala#scalac#GetExecutable(bufnr(''))
-  AssertEqual '', ale_linters#scala#scalac#GetCommand(bufnr(''))
-- 
cgit v1.2.3