From 6503b85d3d0f01d8fa74f8024fda8d6fe0d62274 Mon Sep 17 00:00:00 2001 From: w0rp Date: Wed, 29 Nov 2017 10:08:54 +0000 Subject: Fix #1178 - Don't use the output from eslint_d for fixing files when the output is an error message --- test/fixers/test_eslint_fixer_callback.vader | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) (limited to 'test') diff --git a/test/fixers/test_eslint_fixer_callback.vader b/test/fixers/test_eslint_fixer_callback.vader index afb267a2..aafc4e71 100644 --- a/test/fixers/test_eslint_fixer_callback.vader +++ b/test/fixers/test_eslint_fixer_callback.vader @@ -101,6 +101,7 @@ Execute(--fix-to-stdout should be used for eslint_d): \ 'command': \ ale#Escape(ale#path#Winify(g:dir . '/../eslint-test-files/app-with-eslint-d/node_modules/.bin/eslint_d')) \ . ' --stdin-filename %s --stdin --fix-to-stdout', + \ 'process_with': 'ale#fixers#eslint#ProcessEslintDOutput', \ }, \ ale#fixers#eslint#ApplyFixForVersion(bufnr(''), ['v3.19.0 (eslint_d v4.2.0)']) @@ -110,6 +111,7 @@ Execute(--fix-to-stdout should be used for eslint_d): \ 'command': \ ale#Escape(ale#path#Winify(g:dir . '/../eslint-test-files/app-with-eslint-d/node_modules/.bin/eslint_d')) \ . ' --stdin-filename %s --stdin --fix-to-stdout', + \ 'process_with': 'ale#fixers#eslint#ProcessEslintDOutput', \ }, \ ale#fixers#eslint#ApplyFixForVersion(bufnr(''), ['4.9.0']) @@ -150,3 +152,21 @@ Execute(The --fix-dry-run post-processor should handle JSON output correctly): AssertEqual \ ['foo', 'bar'], \ ale#fixers#eslint#ProcessFixDryRunOutput(bufnr(''), ['[{"output": "foo\nbar"}]']) + +Execute(The eslint_d post-processor should permit regular JavaScript content): + AssertEqual + \ [ + \ 'const x = ''Error: foo''', + \ 'const y = 3', + \ ], + \ ale#fixers#eslint#ProcessEslintDOutput(bufnr(''), [ + \ 'const x = ''Error: foo''', + \ 'const y = 3', + \ ]) + +Execute(The eslint_d post-processor should handle error messages correctly): + AssertEqual + \ [], + \ ale#fixers#eslint#ProcessEslintDOutput(bufnr(''), [ + \ 'Error: No ESLint configuration found.', + \ ]) -- cgit v1.2.3