From 29e5ffe35a2fa1ca5ba19eebfe7cdd0191c16e39 Mon Sep 17 00:00:00 2001 From: Craig Rodrigues Date: Tue, 27 Jun 2023 02:52:50 -0700 Subject: Remove golint supported-tools (#4535) golint has been deprecated and was archived in 2019 --- test/handler/test_golangci_lint_handler.vader | 16 -------------- test/linter/test_golint.vader | 30 --------------------------- test/test_filetype_linter_defaults.vader | 2 +- 3 files changed, 1 insertion(+), 47 deletions(-) delete mode 100644 test/linter/test_golint.vader (limited to 'test') diff --git a/test/handler/test_golangci_lint_handler.vader b/test/handler/test_golangci_lint_handler.vader index 58815f56..7bb6b877 100644 --- a/test/handler/test_golangci_lint_handler.vader +++ b/test/handler/test_golangci_lint_handler.vader @@ -16,17 +16,9 @@ Execute (The golangci-lint handler should handle names with spaces): \ 'expected ''package'', found ''IDENT'' gibberish', \ 'staticcheck', \ ], - \ [ - \ 'C:\something\file with spaces.go', - \ '37', - \ '5', - \ 'expected ''package'', found ''IDENT'' gibberish', - \ 'golint', - \ ], \ ], \ map(ale_linters#go#golangci_lint#GetMatches([ \ 'C:\something\file with spaces.go:12:3: expected ''package'', found ''IDENT'' gibberish (staticcheck)', - \ 'C:\something\file with spaces.go:37:5: expected ''package'', found ''IDENT'' gibberish (golint)', \ ]), 'v:val[1:5]') Execute (The golangci-lint handler should handle paths correctly): @@ -43,17 +35,9 @@ Execute (The golangci-lint handler should handle paths correctly): \ 'type': 'W', \ 'filename': ale#path#Simplify(expand('%:p:h') . '/test.go'), \ }, - \ { - \ 'lnum': 37, - \ 'col': 5, - \ 'text': 'expected ''package'', found ''IDENT'' gibberish (golint)', - \ 'type': 'W', - \ 'filename': ale#path#Simplify(expand('%:p:h') . '/test.go'), - \ }, \ ], \ ale_linters#go#golangci_lint#Handler(bufnr(''), [ \ file . ':12:3: expected ''package'', found ''IDENT'' gibberish (staticcheck)', - \ file . ':37:5: expected ''package'', found ''IDENT'' gibberish (golint)', \ ]) Execute (The golangci-lint handler should handle only typecheck lines as errors): diff --git a/test/linter/test_golint.vader b/test/linter/test_golint.vader deleted file mode 100644 index 64916707..00000000 --- a/test/linter/test_golint.vader +++ /dev/null @@ -1,30 +0,0 @@ -Before: - Save g:ale_go_go111module - - call ale#assert#SetUpLinterTest('go', 'golint') - -After: - Restore - - unlet! b:ale_go_go111module - - call ale#assert#TearDownLinterTest() - -Execute(The default golint command should be correct): - AssertLinter 'golint', ale#Escape('golint') . ' %t' - -Execute(The golint executable should be configurable): - let b:ale_go_golint_executable = 'foobar' - - AssertLinter 'foobar', ale#Escape('foobar') . ' %t' - -Execute(The golint options should be configurable): - let b:ale_go_golint_options = '--foo' - - AssertLinter 'golint', ale#Escape('golint') . ' --foo %t' - -Execute(The golint command should support Go environment variables): - let b:ale_go_go111module = 'on' - - AssertLinter 'golint', - \ ale#Env('GO111MODULE', 'on') . ale#Escape('golint') . ' %t' diff --git a/test/test_filetype_linter_defaults.vader b/test/test_filetype_linter_defaults.vader index ca73a8e5..987257f7 100644 --- a/test/test_filetype_linter_defaults.vader +++ b/test/test_filetype_linter_defaults.vader @@ -36,7 +36,7 @@ Execute(The defaults for the elixir filetype should be correct): AssertEqual [], GetLinterNames('elixir') Execute(The defaults for the go filetype should be correct): - AssertEqual ['gofmt', 'golint', 'gopls', 'govet'], GetLinterNames('go') + AssertEqual ['gofmt', 'gopls', 'govet'], GetLinterNames('go') let g:ale_linters_explicit = 1 -- cgit v1.2.3