From 766636e0c436d8508ae45c51df9229745b4d05d1 Mon Sep 17 00:00:00 2001
From: "brian m. carlson" <sandals@crustytoothpaste.net>
Date: Sat, 26 Jan 2019 04:45:22 +0000
Subject: test/lsp: ensure linter name is set

All linters should have a name variable set in their dictionary, and
code should be able to rely on that. Fix this test such that its example
linter contains a name entry.
---
 test/lsp/test_lsp_command_formatting.vader | 1 +
 1 file changed, 1 insertion(+)

(limited to 'test/lsp')

diff --git a/test/lsp/test_lsp_command_formatting.vader b/test/lsp/test_lsp_command_formatting.vader
index 9721f37f..fcd4f78c 100644
--- a/test/lsp/test_lsp_command_formatting.vader
+++ b/test/lsp/test_lsp_command_formatting.vader
@@ -17,6 +17,7 @@ Execute(Command formatting should be applied correctly for LSP linters):
   call ale#lsp_linter#StartLSP(
   \ bufnr(''),
   \ {
+  \   'name': 'linter',
   \   'language_callback': {-> 'x'},
   \   'project_root_callback': {-> '/foo/bar'},
   \   'lsp': 'stdio',
-- 
cgit v1.2.3


From 6fc016ad052725e0d6a474e80f817cb1853e98e2 Mon Sep 17 00:00:00 2001
From: "brian m. carlson" <sandals@crustytoothpaste.net>
Date: Sat, 26 Jan 2019 04:45:12 +0000
Subject: Add additional ways to detect LSP project root

Currently, we detect the linter root based on a variety of techniques.
However, these techniques are not foolproof. For example, clangd works
fine for many things without a compile_commands.json file, and Go
projects may be built outside of the GOPATH to take advantage of Go
1.11's automatic module support.

Add global and buffer-specific variables to allow the user to specify
the root, either as a string or a funcref. Make the funcrefs accept the
buffer number as an argument to make sure that they can function easily
in an asynchronous environment.

We define the global variable in the main plugin, since the LSP linter
code is not loaded unless required, and we want the variable to be able
to be read correctly by :ALEInfo regardless.
---
 test/lsp/test_lsp_root_detection.vader | 63 ++++++++++++++++++++++++++++++++++
 1 file changed, 63 insertions(+)
 create mode 100644 test/lsp/test_lsp_root_detection.vader

(limited to 'test/lsp')

diff --git a/test/lsp/test_lsp_root_detection.vader b/test/lsp/test_lsp_root_detection.vader
new file mode 100644
index 00000000..2575a62c
--- /dev/null
+++ b/test/lsp/test_lsp_root_detection.vader
@@ -0,0 +1,63 @@
+Before:
+  call ale#assert#SetUpLinterTest('c', 'clangd')
+
+  function! Hook1(buffer)
+    return 'abc123'
+  endfunction
+
+After:
+  let g:ale_lsp_root = {}
+  unlet! b:ale_lsp_root
+  delfunction Hook1
+
+  call ale#assert#TearDownLinterTest()
+
+Execute(The buffer-specific variable can be a string):
+  let b:ale_lsp_root = '/some/path'
+  call ale#test#SetFilename('other-file.c')
+
+  AssertLSPProjectFull '/some/path'
+
+Execute(The buffer-specific variable can be a dictionary):
+  let b:ale_lsp_root = {'clangd': '/some/path', 'golangserver': '/other/path'}
+  call ale#test#SetFilename('other-file.c')
+
+  AssertLSPProjectFull '/some/path'
+
+Execute(The buffer-specific variable can have funcrefs):
+  let b:ale_lsp_root = {'clangd': function('Hook1'), 'golangserver': '/path'}
+  call ale#test#SetFilename('other-file.c')
+
+  AssertLSPProjectFull 'abc123'
+
+Execute(The global variable can be a dictionary):
+  let g:ale_lsp_root = {'clangd': '/some/path', 'golangserver': '/other/path'}
+  call ale#test#SetFilename('other-file.c')
+
+  AssertLSPProjectFull '/some/path'
+
+Execute(The global variable can have funcrefs):
+  let g:ale_lsp_root = {'clangd': function('Hook1'), 'golangserver': '/path'}
+  call ale#test#SetFilename('other-file.c')
+
+  AssertLSPProjectFull 'abc123'
+
+Execute(The buffer-specific variable overrides the global variable):
+  let b:ale_lsp_root = {'clangd': '/some/path', 'golangserver': '/other/path'}
+  let g:ale_lsp_root = {'clangd': '/not/this/path', 'golangserver': '/elsewhere'}
+  call ale#test#SetFilename('other-file.c')
+
+  AssertLSPProjectFull '/some/path'
+
+Execute(The global variable is queried if the buffer-specific has no value):
+  let b:ale_lsp_root = {'golangserver': '/other/path'}
+  let g:ale_lsp_root = {'clangd': '/some/path', 'golangserver': '/elsewhere'}
+  call ale#test#SetFilename('other-file.c')
+
+  AssertLSPProjectFull '/some/path'
+
+
+Execute(The default hook value is acceptable):
+  call ale#test#SetFilename('other-file.c')
+
+  AssertLSPProjectFull ''
-- 
cgit v1.2.3