From 24a937e04f3c59add32d8bd8533e02ab93268772 Mon Sep 17 00:00:00 2001
From: Horacio Sanson <900716+hsanson@users.noreply.github.com>
Date: Wed, 28 Feb 2024 10:07:22 +0900
Subject: Fix 4586 - Make golangci-lint lint package on by default. (#4730)

Checking whole packages instead of individual files is more sensible
default for golang projects. Without this we get many cryptic
`typecheck` errors in ALE that do not show when running in terminal or
CI.
---
 test/linter/test_golangci_lint.vader | 21 +++++++++------------
 1 file changed, 9 insertions(+), 12 deletions(-)

(limited to 'test/linter/test_golangci_lint.vader')

diff --git a/test/linter/test_golangci_lint.vader b/test/linter/test_golangci_lint.vader
index c4dfb79b..3d41cfe4 100644
--- a/test/linter/test_golangci_lint.vader
+++ b/test/linter/test_golangci_lint.vader
@@ -14,25 +14,22 @@ After:
 Execute(The golangci-lint defaults should be correct):
   AssertLinterCwd '%s:h',
   AssertLinter 'golangci-lint',
-  \ ale#Escape('golangci-lint')
-  \   . ' run ' . ale#Escape(expand('%' . ':t'))
-  \   . ' '
+  \ ale#Escape('golangci-lint') . ' run '
 
 Execute(The golangci-lint callback should use a configured executable):
   let b:ale_go_golangci_lint_executable = 'something else'
 
   AssertLinter 'something else',
   \ ale#Escape('something else')
-  \   . ' run ' . ale#Escape(expand('%' . ':t'))
-  \   . ' '
+  \   . ' run '
 
 Execute(The golangci-lint callback should use configured options):
   let b:ale_go_golangci_lint_options = '--foobar'
 
   AssertLinter 'golangci-lint',
   \ ale#Escape('golangci-lint')
-  \   . ' run ' . ale#Escape(expand('%' . ':t'))
-  \   . ' --foobar'
+  \   . ' run '
+  \   . '--foobar'
 
 Execute(The golangci-lint callback should support environment variables):
   let b:ale_go_go111module = 'on'
@@ -40,11 +37,11 @@ Execute(The golangci-lint callback should support environment variables):
   AssertLinter 'golangci-lint',
   \ ale#Env('GO111MODULE', 'on')
   \   . ale#Escape('golangci-lint')
-  \   . ' run ' . ale#Escape(expand('%' . ':t'))
-  \   . ' '
+  \   . ' run '
 
 Execute(The golangci-lint `lint_package` option should use the correct command):
-  let b:ale_go_golangci_lint_package = 1
-
+  let b:ale_go_golangci_lint_package = 0
   AssertLinter 'golangci-lint',
-  \ ale#Escape('golangci-lint') . ' run '
+  \ ale#Escape('golangci-lint')
+  \   . ' run ' . ale#Escape(expand('%' . ':t'))
+  \   . ' '
-- 
cgit v1.2.3