From dcbb0ffee536754df014085b03bf65cd2c21150f Mon Sep 17 00:00:00 2001 From: Eddie Lebow Date: Wed, 12 Jul 2017 19:42:54 -0400 Subject: Rubocop: handle empty 'files' array in output The handler previously assumed there would be at least one entry in the 'files' array in the output JSON. It looks like this in the normal case: "files":[{"path":"app/models/image.rb","offenses":[]}] But if RuboCop's config excludes the specified input files, causing no files to be linted, the output is emptier: "files":[] This change causes the handler to treat that case correctly, and also exit early if the reported offense_count is zero. --- ale_linters/ruby/rubocop.vim | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'ale_linters') diff --git a/ale_linters/ruby/rubocop.vim b/ale_linters/ruby/rubocop.vim index 9d315be1..a539b1ae 100644 --- a/ale_linters/ruby/rubocop.vim +++ b/ale_linters/ruby/rubocop.vim @@ -28,6 +28,10 @@ function! ale_linters#ruby#rubocop#Handle(buffer, lines) abort \}] endtry + if l:errors['summary']['offense_count'] == 0 || empty(l:errors['files']) + return [] + endif + let l:output = [] for l:error in l:errors['files'][0]['offenses'] -- cgit v1.2.3