From 4b0f3257ddf4303a00979cd1171dd449bd3b9ed5 Mon Sep 17 00:00:00 2001 From: Adriaan Zonnenberg Date: Fri, 31 Mar 2017 00:33:38 +0200 Subject: Remove 'col' from linters where it is hardcoded to 1 (#434) * Remove 'col' from linters where it is hardcoded to 1 When 'col' is 1, the first column will get highlighted for no reason. It should be 0 (which is the default). In the scalac linter there was also a check about the outcome of `stridx`. It would set l:col to 0 if it was -1, and then it uses `'col': l:col + 1` to convert the outcome of `stridx` to the actual column number. This will make 'col' equals 1 when there is no match. We can remove the check because `-1 + 1 = 0`. * Remove outdated comments about vcol vcol was added as a default, and the loclists that follow these comments do not contain 'vcol' anymore --- ale_linters/perl/perlcritic.vim | 3 --- 1 file changed, 3 deletions(-) (limited to 'ale_linters/perl/perlcritic.vim') diff --git a/ale_linters/perl/perlcritic.vim b/ale_linters/perl/perlcritic.vim index f146085d..8f31e513 100644 --- a/ale_linters/perl/perlcritic.vim +++ b/ale_linters/perl/perlcritic.vim @@ -13,15 +13,12 @@ function! ale_linters#perl#perlcritic#Handle(buffer, lines) abort endif let l:line = l:match[3] - let l:column = 1 let l:text = l:match[1] let l:type = 'E' - " vcol is Needed to indicate that the column is a character. call add(l:output, { \ 'bufnr': a:buffer, \ 'lnum': l:line, - \ 'col': l:column, \ 'text': l:text, \ 'type': l:type, \}) -- cgit v1.2.3