From c290e2cd602a20f71880ea1d210797fad2db8000 Mon Sep 17 00:00:00 2001
From: Bjorn Neergaard <bjorn@neersighted.com>
Date: Tue, 11 Oct 2016 09:22:47 -0500
Subject: Remove many redundant handlers

---
 ale_linters/javascript/jscs.vim   | 40 ++----------------------------------
 ale_linters/javascript/jshint.vim | 43 ++-------------------------------------
 2 files changed, 4 insertions(+), 79 deletions(-)

(limited to 'ale_linters/javascript')

diff --git a/ale_linters/javascript/jscs.vim b/ale_linters/javascript/jscs.vim
index 1853c894..501a3288 100644
--- a/ale_linters/javascript/jscs.vim
+++ b/ale_linters/javascript/jscs.vim
@@ -7,52 +7,16 @@ endif
 
 let g:loaded_ale_linters_javascript_jscs = 1
 
-function! ale_linters#javascript#jscs#Handle(buffer, lines)
-    " Matches patterns line the following:
-    "
-    " input:57:8: Unexpected token (57:8)
-    let l:pattern = '^.\+:\(\d\+\):\(\d\+\): \(.\+\)'
-    let l:output = []
-
-    for l:line in a:lines
-        let l:match = matchlist(l:line, l:pattern)
-
-        if len(l:match) == 0
-            continue
-        endif
-
-        let l:text = l:match[3]
-        let l:marker_parts = l:match[4]
-
-        if len(l:marker_parts) == 2
-            let l:text = l:text . ' (' . l:marker_parts[1] . ')'
-        endif
-
-        " vcol is Needed to indicate that the column is a character.
-        call add(l:output, {
-        \   'bufnr': a:buffer,
-        \   'lnum': l:match[1] + 0,
-        \   'vcol': 0,
-        \   'col': l:match[2] + 0,
-        \   'text': l:text,
-        \   'type': 'E',
-        \   'nr': -1,
-        \})
-    endfor
-
-    return l:output
-endfunction
-
 call ale#linter#Define('javascript', {
 \   'name': 'jscs',
 \   'executable': 'jscs',
 \   'command': 'jscs -r unix -n -',
-\   'callback': 'ale_linters#javascript#jscs#Handle',
+\   'callback': 'ale#handlers#HandleUnixFormatAsError',
 \})
 
 call ale#linter#Define('javascript.jsx', {
 \   'name': 'jscs',
 \   'executable': 'jscs',
 \   'command': 'jscs -r unix -n -',
-\   'callback': 'ale_linters#javascript#jscs#Handle',
+\   'callback': 'ale#handlers#HandleUnixFormatAsError',
 \})
diff --git a/ale_linters/javascript/jshint.vim b/ale_linters/javascript/jshint.vim
index 6dbd4c2a..571d05d7 100644
--- a/ale_linters/javascript/jshint.vim
+++ b/ale_linters/javascript/jshint.vim
@@ -31,55 +31,16 @@ function! ale_linters#javascript#jshint#GetCommand(buffer)
     return l:command
 endfunction
 
-function! ale_linters#javascript#jshint#Handle(buffer, lines)
-    " Matches patterns line the following:
-    "
-    " stdin:57:9: Missing name in function declaration.
-    " stdin:60:5: Attempting to override 'test2' which is a constant.
-    " stdin:57:10: 'test' is defined but never used.
-    " stdin:57:1: 'function' is defined but never used.
-    let l:pattern = '^.\+:\(\d\+\):\(\d\+\): \(.\+\)'
-    let l:output = []
-
-    for l:line in a:lines
-        let l:match = matchlist(l:line, l:pattern)
-
-        if len(l:match) == 0
-            continue
-        endif
-
-        let l:text = l:match[3]
-        let l:marker_parts = l:match[4]
-
-        if len(l:marker_parts) == 2
-            let l:text = l:text . ' (' . l:marker_parts[1] . ')'
-        endif
-
-        " vcol is Needed to indicate that the column is a character.
-        call add(l:output, {
-        \   'bufnr': a:buffer,
-        \   'lnum': l:match[1] + 0,
-        \   'vcol': 0,
-        \   'col': l:match[2] + 0,
-        \   'text': l:text,
-        \   'type': 'E',
-        \   'nr': -1,
-        \})
-    endfor
-
-    return l:output
-endfunction
-
 call ale#linter#Define('javascript', {
 \   'name': 'jshint',
 \   'executable': g:ale_javascript_jshint_executable,
 \   'command_callback': 'ale_linters#javascript#jshint#GetCommand',
-\   'callback': 'ale_linters#javascript#jshint#Handle',
+\   'callback': 'ale#handlers#HandleUnixFormatAsError',
 \})
 
 call ale#linter#Define('javascript.jsx', {
 \   'name': 'jshint',
 \   'executable': g:ale_javascript_jshint_executable,
 \   'command_callback': 'ale_linters#javascript#jshint#GetCommand',
-\   'callback': 'ale_linters#javascript#jshint#Handle',
+\   'callback': 'ale#handlers#HandleUnixFormatAsError',
 \})
-- 
cgit v1.2.3