From b9f02ffb275b1d120967ab163e79959d3673ffd6 Mon Sep 17 00:00:00 2001 From: Jeff Willette Date: Mon, 20 Nov 2017 23:50:14 +0900 Subject: Added filename key for `go build` linter - Re: f224ce8a377bbb3a0deb78b98fdc6c43555791e2 - The issues that prompted the above commit which reverted changes made to `go build` and `gometalinter` seemed to suggest that the main issue was with gometalinter and that changes should be put into different commits so they are independent of each other - This commit reinstates the changes to the `go build` linter which seem to be uncontested and it also seems absolutely necessary to show errors from all files in the package which may have caused a build failure. --- ale_linters/go/gobuild.vim | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'ale_linters/go/gobuild.vim') diff --git a/ale_linters/go/gobuild.vim b/ale_linters/go/gobuild.vim index 143c2fd0..783b9e0a 100644 --- a/ale_linters/go/gobuild.vim +++ b/ale_linters/go/gobuild.vim @@ -1,4 +1,5 @@ -" Author: Joshua Rubin , Ben Reedy +" Author: Joshua Rubin , Ben Reedy , +" Jeff Willette " Description: go build for Go files " inspired by work from dzhou121 @@ -39,15 +40,12 @@ function! ale_linters#go#gobuild#GetMatches(lines) abort endfunction function! ale_linters#go#gobuild#Handler(buffer, lines) abort + let l:dir = expand('#' . a:buffer . ':p:h') let l:output = [] for l:match in ale_linters#go#gobuild#GetMatches(a:lines) - " Omit errors from imported go packages - if !ale#path#IsBufferPath(a:buffer, l:match[1]) - continue - endif - call add(l:output, { + \ 'filename': ale#path#GetAbsPath(l:dir, l:match[1]), \ 'lnum': l:match[2] + 0, \ 'col': l:match[3] + 0, \ 'text': l:match[4], -- cgit v1.2.3