From fb4b797dd22b2ec225542c97e5c0c4195edf037e Mon Sep 17 00:00:00 2001 From: Bjorn Neergaard Date: Mon, 10 Oct 2016 18:43:45 -0500 Subject: Use explicit scope in all ale_linters vint -s is now clean --- ale_linters/d/dmd.vim | 42 +++++++++++++++++++++--------------------- 1 file changed, 21 insertions(+), 21 deletions(-) (limited to 'ale_linters/d') diff --git a/ale_linters/d/dmd.vim b/ale_linters/d/dmd.vim index 0fdf0bac..c9e3a2c2 100644 --- a/ale_linters/d/dmd.vim +++ b/ale_linters/d/dmd.vim @@ -9,56 +9,56 @@ let g:loaded_ale_linters_d_dmd = 1 " A function for finding the dmd-wrapper script in the Vim runtime paths function! s:FindWrapperScript() - for parent in split(&runtimepath, ',') + for l:parent in split(&runtimepath, ',') " Expand the path to deal with ~ issues. - let path = expand(parent . '/' . 'dmd-wrapper') + let l:path = expand(l:parent . '/' . 'dmd-wrapper') - if filereadable(path) - return path + if filereadable(l:path) + return l:path endif endfor endfunction function! ale_linters#d#dmd#GetCommand(buffer) - let wrapper_script = s:FindWrapperScript() + let l:wrapper_script = s:FindWrapperScript() - let command = wrapper_script . ' -o- -vcolumns -c' + let l:command = l:wrapper_script . ' -o- -vcolumns -c' - return command + return l:command endfunction function! ale_linters#d#dmd#Handle(buffer, lines) " Matches patterns lines like the following: " " /tmp/tmp.G1L5xIizvB.d(8,8): Error: module weak_reference is in file 'dstruct/weak_reference.d' which cannot be read - let pattern = '^[^(]\+(\([0-9]\+\),\([0-9]\+\)): \([^:]\+\): \(.\+\)' - let output = [] + let l:pattern = '^[^(]\+(\([0-9]\+\),\([0-9]\+\)): \([^:]\+\): \(.\+\)' + let l:output = [] - for line in a:lines - let l:match = matchlist(line, pattern) + for l:line in a:lines + let l:match = matchlist(l:line, l:pattern) if len(l:match) == 0 break endif - let line = l:match[1] + 0 - let column = l:match[2] + 0 - let type = l:match[3] - let text = l:match[4] + let l:line = l:match[1] + 0 + let l:column = l:match[2] + 0 + let l:type = l:match[3] + let l:text = l:match[4] " vcol is Needed to indicate that the column is a character. - call add(output, { + call add(l:output, { \ 'bufnr': bufnr('%'), - \ 'lnum': line, + \ 'lnum': l:line, \ 'vcol': 0, - \ 'col': column, - \ 'text': text, - \ 'type': type ==# 'Warning' ? 'W' : 'E', + \ 'col': l:column, + \ 'text': l:text, + \ 'type': l:type ==# 'Warning' ? 'W' : 'E', \ 'nr': -1, \}) endfor - return output + return l:output endfunction call ale#linter#Define('d', { -- cgit v1.2.3