From bdd8d2399f59f32c5531d168a1f9402d42d9b299 Mon Sep 17 00:00:00 2001
From: w0rp <devw0rp@gmail.com>
Date: Sun, 18 Mar 2018 16:48:28 +0000
Subject: #416 Escape the tslint command

---
 ale_linters/typescript/tslint.vim                        |  2 +-
 test/command_callback/test_tslint_command_callback.vader | 16 ++++++++++++++--
 2 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/ale_linters/typescript/tslint.vim b/ale_linters/typescript/tslint.vim
index f4b48169..6f94fbae 100644
--- a/ale_linters/typescript/tslint.vim
+++ b/ale_linters/typescript/tslint.vim
@@ -70,7 +70,7 @@ function! ale_linters#typescript#tslint#GetCommand(buffer) abort
     \  : ''
 
     return ale#path#BufferCdString(a:buffer)
-    \   . ale_linters#typescript#tslint#GetExecutable(a:buffer)
+    \   . ale#Escape(ale_linters#typescript#tslint#GetExecutable(a:buffer))
     \   . ' --format json'
     \   . l:tslint_config_option
     \   . l:tslint_rules_option
diff --git a/test/command_callback/test_tslint_command_callback.vader b/test/command_callback/test_tslint_command_callback.vader
index 4ad42fa5..edab72c8 100644
--- a/test/command_callback/test_tslint_command_callback.vader
+++ b/test/command_callback/test_tslint_command_callback.vader
@@ -17,7 +17,10 @@ Before:
 After:
   Restore
 
+  unlet! b:ale_typescript_tslint_executable
+  unlet! b:ale_typescript_tslint_config_path
   unlet! b:ale_typescript_tslint_rules_dir
+  unlet! b:ale_typescript_tslint_use_global
 
   call ale#test#RestoreDirectory()
   call ale#linter#Reset()
@@ -25,7 +28,7 @@ After:
 Execute(The default tslint command should be correct):
   AssertEqual
   \ 'cd ' . ale#Escape(expand('%:p:h')) . ' && '
-  \   . 'tslint --format json %t',
+  \   . ale#Escape('tslint') . ' --format json %t',
   \ ale_linters#typescript#tslint#GetCommand(bufnr(''))
 
 Execute(The rules directory option should be included if set):
@@ -33,7 +36,16 @@ Execute(The rules directory option should be included if set):
 
   AssertEqual
   \ 'cd ' . ale#Escape(expand('%:p:h')) . ' && '
-  \   . 'tslint --format json'
+  \   . ale#Escape('tslint') . ' --format json'
   \   . ' -r ' . ale#Escape('/foo/bar')
   \   . ' %t',
   \ ale_linters#typescript#tslint#GetCommand(bufnr(''))
+
+Execute(The executable should be configurable and escaped):
+  let b:ale_typescript_tslint_executable = 'foo bar'
+
+  AssertEqual 'foo bar', ale_linters#typescript#tslint#GetExecutable(bufnr(''))
+  AssertEqual
+  \ 'cd ' . ale#Escape(expand('%:p:h')) . ' && '
+  \   . ale#Escape('foo bar') . ' --format json %t',
+  \ ale_linters#typescript#tslint#GetCommand(bufnr(''))
-- 
cgit v1.2.3