From d84fcf6c3c0d492cf20e4c32566163e94ee6703d Mon Sep 17 00:00:00 2001 From: KtorZ Date: Tue, 11 Sep 2018 17:17:55 +0200 Subject: Define custom vim global variables to pass options to hlint --- ale_linters/haskell/hlint.vim | 15 +++++++++++++-- doc/ale-haskell.txt | 9 +++++++++ 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/ale_linters/haskell/hlint.vim b/ale_linters/haskell/hlint.vim index be40d92c..3ee864bf 100644 --- a/ale_linters/haskell/hlint.vim +++ b/ale_linters/haskell/hlint.vim @@ -1,6 +1,9 @@ " Author: jparoz " Description: hlint for Haskell files +call ale#Set('haskell_hlint_executable', 'hlint') +call ale#Set('haskell_hlint_options', get(g:, 'hlint_options', '')) + function! ale_linters#haskell#hlint#Handle(buffer, lines) abort let l:output = [] @@ -26,9 +29,17 @@ function! ale_linters#haskell#hlint#Handle(buffer, lines) abort return l:output endfunction +function! ale_linters#haskell#hlint#GetCommand(buffer) abort + let l:hlintopts = '--color=never --json' + + return '%e' + \ . ' ' . ale#Var(a:buffer, 'haskell_hlint_options') + \ . ' ' . l:hlintopts . ' -' +endfunction + call ale#linter#Define('haskell', { \ 'name': 'hlint', -\ 'executable': 'hlint', -\ 'command': 'hlint --color=never --json -', +\ 'executable_callback': ale#VarFunc('haskell_hlint_executable'), +\ 'command_callback': 'ale_linters#haskell#hlint#GetCommand', \ 'callback': 'ale_linters#haskell#hlint#Handle', \}) diff --git a/doc/ale-haskell.txt b/doc/ale-haskell.txt index c1f1e889..a59fa4e2 100644 --- a/doc/ale-haskell.txt +++ b/doc/ale-haskell.txt @@ -77,6 +77,15 @@ g:ale_haskell_hlint_executable *g:ale_haskell_hlint_executable* This variable can be changed to use a different executable for hlint. + +g:ale_haskell_hlint_options g:ale_haskell_hlint_options + b:ale_haskell_hlint_options + Type: String + Default: '' + + This variable can be used to pass extra options to the underlying hlint + executable. + =============================================================================== stack-build *ale-haskell-stack-build* -- cgit v1.2.3 From bd32b7c856937cfe8dae67907b9bde19b6bccb80 Mon Sep 17 00:00:00 2001 From: KtorZ Date: Tue, 18 Sep 2018 08:25:49 +0200 Subject: Add command_callback tests to cover hlint config variables --- .../test_haskell_hlint_command_callbacks.vader | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 test/command_callback/test_haskell_hlint_command_callbacks.vader diff --git a/test/command_callback/test_haskell_hlint_command_callbacks.vader b/test/command_callback/test_haskell_hlint_command_callbacks.vader new file mode 100644 index 00000000..fb354ed4 --- /dev/null +++ b/test/command_callback/test_haskell_hlint_command_callbacks.vader @@ -0,0 +1,16 @@ +Before: + call ale#assert#SetUpLinterTest('haskell', 'hlint') + let b:base_opts = '--color=never --json -' + +After: + unlet! b:base_opts + call ale#assert#TearDownLinterTest() + +Execute(executable should be configurable): + AssertLinter 'hlint', ale#Escape('hlint') . ' ' . b:base_opts + let b:ale_haskell_hlint_executable = 'myHlint' + AssertLinter 'myHlint', ale#Escape('myHlint') . ' ' . b:base_opts + +Execute(should accept options): + let b:ale_haskell_hlint_options= '-h myhlintfile.yaml' + AssertLinter 'hlint', ale#Escape('hlint') . ' -h myhlintfile.yaml ' . b:base_opts -- cgit v1.2.3