summaryrefslogtreecommitdiff
path: root/ale_linters/ruby
AgeCommit message (Collapse)Author
2017-11-14#852 - Capture error codes for RubocopAliou Diallo
2017-09-13Report problems in other files for brakeman, and get the tests to pass on ↵w0rp
Windows
2017-08-08Ban use of ==# or ==? in the codebase, and prefer is# or is? insteadw0rp
2017-08-02Rubocop: Show cop nameJunegunn Choi
2017-07-27#810 - Handle output which is not JSON in many lintersw0rp
2017-07-26#810 Ignore output which isn't JSON for brakemanw0rp
2017-07-13#769 Ignore stderr output and output without JSON we can read for rubocopw0rp
2017-07-12Rubocop: handle empty 'files' array in outputEddie Lebow
The handler previously assumed there would be at least one entry in the 'files' array in the output JSON. It looks like this in the normal case: "files":[{"path":"app/models/image.rb","offenses":[]}] But if RuboCop's config excludes the specified input files, causing no files to be linted, the output is emptier: "files":[] This change causes the handler to treat that case correctly, and also exit early if the reported offense_count is zero.
2017-07-12Fix #760 - Report problems with configuration files for rubocopw0rp
2017-07-12Add rails_best_practices handler (resolves #655) (#751)Eddie Lebow
* Move FindRailsRoot() to more general location * Add rails_best_practices handler (resolves #655) * Update documentation for rails_best_practices Also add brakeman to *ale* documentation. * rails_best_practices: allow overriding the executable * rails_best_practices: format help correctly * rails_best_practices: capture tool output on Windows
2017-07-09Make every test set filenames and switch directories in the same way, and ↵w0rp
fix some missing escaping for the rubocop linter
2017-07-09Fix some indentationw0rp
2017-07-09Simplify ale_linters#ruby#rubocop#GetTypew0rp
2017-07-09Use rubocop's JSON output format (resolves #339) (#738)Eddie Lebow
* Use rubocop's JSON output format (resolves #339) Rubocop's emacs formatter seems to have changed format in some not-so-ancient version. The JSON formatter should provide a more stable interface than parsing lines with a regex. The JSON formatter was introduced in mid-2013, so it should be safe to assume available in any reasonably-modern environment. The oldest currently-supported version of ruby (according to ruby-lang.org) was not supported by rubocop until 2014. * Rubocop: Use global function for GetType * Rubocop: Use scope prefix in GetType * Rubocop: Update command_callback test * Rubocop: add end_col to Handle
2017-07-06Initialize rubocop variables in one placew0rp
2017-07-01Fix brakeman handler when there is no outputGabriel Sobrinho
2017-06-21Fix some escaping and make some tests set filenames consistentlyw0rp
2017-05-18Clean up the rubocop file a littlew0rp
2017-05-17Escape executableDevon Meunier
2017-05-16Allow overriding rubocop executable.Devon Meunier
2017-05-05[RFC] Add Brakeman for Ruby on Rails (references #385) (#509)Eddie Lebow
* Add brakeman for Ruby on Rails
2017-04-25Add erb linter (#497)Matthias Günther
* Add eruby linter * Update README with erb linter * Fix example and contributions * Remove trailing newline * Fix for Vimscript style guide * Eruby-linter: codereview with @w0rp - read from stderro output_stream * Eruby-linter: codereview => add handler for ruby * Eruby-linter: codereview - eruby and ruby lint use the same ruby-handler (removes duplicated handling logic) * Eruby-linter: try to fix tests
2017-04-20Add the Reek checker for Ruby. (#490)Eddie Lebow
Add the Reek checker for Ruby.
2017-04-18Add a function for getting matches, and use it to simplify a lot of codew0rp
2017-04-16#427 Implement buffer variable overrides for all linter optionsw0rp
2017-04-15Make code more consistentw0rp
2017-04-08Add Ruby MRI linter (#453)Brandon Roehl
* Added ruby mri linter * Added to the list of supported linters * Async and now with 4 spaces * Vader tests for ruby * Match style choices * Vader test for the Ruby handler now works and passes
2017-03-30Remove 'col' from linters where it is hardcoded to 1 (#434)Adriaan Zonnenberg
* Remove 'col' from linters where it is hardcoded to 1 When 'col' is 1, the first column will get highlighted for no reason. It should be 0 (which is the default). In the scalac linter there was also a check about the outcome of `stridx`. It would set l:col to 0 if it was -1, and then it uses `'col': l:col + 1` to convert the outcome of `stridx` to the actual column number. This will make 'col' equals 1 when there is no match. We can remove the check because `-1 + 1 = 0`. * Remove outdated comments about vcol vcol was added as a default, and the loclists that follow these comments do not contain 'vcol' anymore
2017-03-27Adjust rubocop error levelsGabriel Holodak
Consider rubocop fatal errors as ALE errors, and rubocop style warnings as ALE warnings.
2017-02-26Copy all loclist items returned from handlers, and set up defaults for ↵w0rp
convenience
2017-02-06Update comments for RuboCop patternChayoung You
2017-02-05Take the rubocop filename from the buffer number given to the functionw0rp
2017-02-03Fix Rubocop filename handlingDerek Prior
In my previous change, I updated the Rubocop linter to pass the filename to Rubocop. This change was tested on a file I expected Rubocop to ignore and the experience in vim was as I expected. However, I soon found that ALE wasn't finding errors in files that should not be ignored. After investigation, I found a few issues that this commit fixes: 1. We were not properly passing the current filename. We now use `expand` to get the filename. 2. The regular expression used in the callback was expecting the static value of `_` for the filename in output. We now use a looser regular expression that begins matching on the first `:`. 3. The linter was defined statically. By using the current filename when defining the command the linter would always use the filename of the first Ruby file the user opened. We now use a `command_callback` to inject the proper filename. I tested these changes on a configuration with included and excluded files and found it to work as I expected. Apologies for the earlier incorrect change.
2017-01-27Enable Rubocop to exclude files based on configDerek Prior
When using `--stdin`, Rubocop requires that you also pass the associated file name. ALE was previously passing `_` as the filename. By passing the actual relative path to the file and enabling the `--force-exclusion` option, we can get Rubocop to respect excluded files in the configuration. Closes #197
2017-01-22Add a script for custom checks to enforce using the abort flag for functions ↵w0rp
and trailing whitespace, and fix existing issues.
2017-01-12Fix #175 - Fix the error types for rubocopw0rp
2016-12-01Add options variable for ruby-rubocopPo Shan Cheah
2016-10-21Add support for dot-seperate linters, improve linter testsBjorn Neergaard
This PR first and formost implements support for dot-seperate filetypes, a very trivial change. This closes #132 But more importantly, this PR vastly improves the test quality for `ale#linter#Get`. It enables us to reset the state of ale's internal linter cache, to facilitate better testing, as well as making use of mocked linters instead of depending on linters on disk (which may change). In addition, a dummy linter is defined to test the autoloading behavior. Header guards were removed from all linters as: * A: ale won't try and load linters if they already exist in memory * B: we can't reset state for testing if they can't be loaded again
2016-10-11Use explicit scope in all ale_lintersBjorn Neergaard
vint -s is now clean
2016-10-10First pass at optimizing ale to autoload (#80)Bjorn Neergaard
* First pass at optimizing ale to autoload First off, the structure/function names should be revised a bit, but I will wait for @w0rp's input before unifying the naming style. Second off, the docs probably need some more work, I just did some simple find-and-replace work. With that said, this pull brings major performance gains for ale. On my slowest system, fully loading ale and all its code takes around 150ms. I have moved all of ale's autoload-able code to autoload/, and in addition, implemented lazy-loading of linters. This brings load time on that same system down to 5ms. The only downside of lazy loading is that `g:ale_linters` cannot be changed at runtime; however, it also speeds up performance at runtime by simplfying the logic greatly. Please let me know what you think! Closes #59 * Address Travis/Vint errors For some reason, ale isn't running vint for me... * Incorporate feedback, make fixes Lazy-loading logic is much improved. * Add header comments; remove incorrect workaround * Remove unneeded plugin guards * Fix lazy-loading linter logic Set the wrong variable.... * Fix capitialization
2016-10-04Add comment headers to ale_lintersPrashanth Chandra
2016-09-16I accidentally credited the wrong guy. Let's fix that.w0rp
2016-09-15Credit fijshion for his work in the files, and make the new linters work ↵w0rp
again by adding the now required name arguments.
2016-09-15FIXED commentsynonp
2016-09-15ADD rubocop linterynonp