| Age | Commit message (Collapse) | Author |
|---|
|
|
|
Fixes #936
|
|
|
|
This fixes issue #936 by linting the whole package
|
|
|
|
|
|
|
|
|
|
* Added option for `gometalinter` to lint package
* added tests for the `gometalinter` command
* changed gometalinter commands to use BufferCdString
|
|
- Re: f224ce8a377bbb3a0deb78b98fdc6c43555791e2
- The issues that prompted the above commit which reverted changes made to `go build` and
`gometalinter` seemed to suggest that the main issue was with gometalinter and that
changes should be put into different commits so they are independent of each other
- This commit reinstates the changes to the `go build` linter which seem to be uncontested
and it also seems absolutely necessary to show errors from all files in the package which
may have caused a build failure.
|
|
This reverts commit e721f851b41b8f6f31067ae2a137019e1cb5546c.
|
|
* Added filename keys to gobuild and gometalinter
* Removed skipping files not in current package
* Removed `--include` for gometalinter
* Fixed the tests
|
|
|
|
|
|
|
|
|
|
|
|
The real fix was not using absolute paths anymore (so not expanding with the `:p` option). The regex was correct and should at least include the `^` character to make sure the string starts with the given path/filename and not references the path/filename in some error description.
|
|
which uses RE2
|
|
They changed their logic to use related paths instead of absoluut paths (see [here](https://github.com/alecthomas/gometalinter/commit/a04df08be5899be3c7ad69aa379858dcb660c709#diff-04424ed7c660c10495a54e8d11be89eaR253))
This fixes the linter by also using relative paths…
|
|
|
|
|
|
* Improve performance when using gometalinter
Before this change when I opened a big project that had 6000+ warnings/errors it took ages to get the actual warnings/errors and it caused my CPU to be busy for quite some time. The call to gometalinter alone took about 24 seconds, but after that vim was struggling as well.
After this change the gometalinter call just takes 2 seconds and nothing noticable happens with the CPU and/or vim.
* Removed obsolete test
This logic is no longer done by the `ale` plugin, but by `gometalinter` itself.
|
|
|
|
|
|
|
|
* go build: skip not current buffer
* fix gobuild_handler.vader
|
|
|
|
|
|
|
|
|
|
Add gometalinter linter for go files
|
|
appropriate
|
|
|
|
Linter is disabled by default (see g:ale_go_gometalinter_enabled) as it
conflicts with a number of established ALE linters (golint, govet,
gosimple, staticcheck, etc).
|
|
Resolves issues with gobuild linter with multiple go source files
belonging to the same go package.
|
|
* #418 Make `go build` linter check files on disk
* Omit errors from imported go packages
|
|
|
|
|
|
convenience
|
|
|
|
* try fixing go build
* cache some system calls
* fix /dev/null
* use chained commands, use `go test -c` instead of `go tool compile`
* fix some unescaped shell commands
* fix a bug with explicitly setting GOPATH
* implement changes requested in code review. handle errors from multiple files. fix issue when starting a new package
* run `go env` as a job
* ensure all functions return the proper type
* fix loclist line numbers in some cases
* remove multibuffer support for now
|
|
Named file file will be created after ALE, this can redirect the output to /dev/null if go build failed.
|
|
* add go build for build errors
* Add go build to doc and README
* Improvement for Go build
Go build works on package level, so copy over the other files
that belong to the same package to the temp folder as well.
* revert back to simple go build
* change gobuild script var name
|
|
This PR first and formost implements support for dot-seperate filetypes,
a very trivial change.
This closes #132
But more importantly, this PR vastly improves the test quality for
`ale#linter#Get`. It enables us to reset the state of ale's internal
linter cache, to facilitate better testing, as well as making use of
mocked linters instead of depending on linters on disk (which may
change). In addition, a dummy linter is defined to test the autoloading
behavior.
Header guards were removed from all linters as:
* A: ale won't try and load linters if they already exist in memory
* B: we can't reset state for testing if they can't be loaded again
|
|
Two wrapper functions allow treating lines as errors or as warnings
|
|
This includes go vet, golint, and gofmt -e
|
