summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--ale_linters/r/lintr.vim6
-rw-r--r--test/command_callback/test_lintr_command_callback.vader16
2 files changed, 12 insertions, 10 deletions
diff --git a/ale_linters/r/lintr.vim b/ale_linters/r/lintr.vim
index 9db63c7c..e1639051 100644
--- a/ale_linters/r/lintr.vim
+++ b/ale_linters/r/lintr.vim
@@ -7,8 +7,9 @@ let g:ale_r_lintr_options = get(g:, 'ale_r_lintr_options', 'with_defaults()')
function! ale_linters#r#lintr#GetCommand(buffer) abort
let l:cmd_string = 'suppressPackageStartupMessages(library(lintr));'
- \ . 'lint(cache = FALSE, commandArgs(TRUE),'
- \ . ale#Var(a:buffer, 'r_lintr_options') . ')'
+ \ . 'lint(cache = FALSE, commandArgs(TRUE),'
+ \ . ale#Var(a:buffer, 'r_lintr_options') . ')'
+
return ale#path#BufferCdString(a:buffer)
\ . 'Rscript -e '
\ . ale#Escape(l:cmd_string) . ' %t'
@@ -21,4 +22,3 @@ call ale#linter#Define('r', {
\ 'callback': 'ale#handlers#gcc#HandleGCCFormat',
\ 'output_stream': 'both',
\})
-
diff --git a/test/command_callback/test_lintr_command_callback.vader b/test/command_callback/test_lintr_command_callback.vader
index 3199b498..256618cf 100644
--- a/test/command_callback/test_lintr_command_callback.vader
+++ b/test/command_callback/test_lintr_command_callback.vader
@@ -17,18 +17,20 @@ Execute(The default lintr command should be correct):
AssertEqual
\ 'cd ' . ale#Escape(getcwd()) . ' && '
\ . 'Rscript -e '
- \ . ale#Escape('lintr::lint(commandArgs(TRUE)[1], eval(parse(text = commandArgs(TRUE)[2])))')
- \ . ' %t '
- \ . ale#Escape('lintr::with_defaults()'),
+ \ . ale#Escape('suppressPackageStartupMessages(library(lintr));'
+ \ . 'lint(cache = FALSE, commandArgs(TRUE),'
+ \ . 'with_defaults())')
+ \ . ' %t',
\ ale_linters#r#lintr#GetCommand(bufnr(''))
Execute(The lintr options should be configurable):
- let b:ale_r_lintr_options = 'lintr::with_defaults(object_usage_linter = NULL)'
+ let b:ale_r_lintr_options = 'with_defaults(object_usage_linter = NULL)'
AssertEqual
\ 'cd ' . ale#Escape(getcwd()) . ' && '
\ . 'Rscript -e '
- \ . ale#Escape('lintr::lint(commandArgs(TRUE)[1], eval(parse(text = commandArgs(TRUE)[2])))')
- \ . ' %t '
- \ . ale#Escape('lintr::with_defaults(object_usage_linter = NULL)'),
+ \ . ale#Escape('suppressPackageStartupMessages(library(lintr));'
+ \ . 'lint(cache = FALSE, commandArgs(TRUE),'
+ \ . 'with_defaults(object_usage_linter = NULL))')
+ \ . ' %t',
\ ale_linters#r#lintr#GetCommand(bufnr(''))