summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--autoload/ale/fixers/standard.vim10
-rw-r--r--test/eslint-test-files/react-app/node_modules/standard/bin/cmd.js0
-rw-r--r--test/fixers/test_standard_fixer_callback.vader32
3 files changed, 41 insertions, 1 deletions
diff --git a/autoload/ale/fixers/standard.vim b/autoload/ale/fixers/standard.vim
index bb457f30..6a0c6b65 100644
--- a/autoload/ale/fixers/standard.vim
+++ b/autoload/ale/fixers/standard.vim
@@ -11,8 +11,16 @@ endfunction
function! ale#fixers#standard#Fix(buffer) abort
let l:executable = ale#fixers#standard#GetExecutable(a:buffer)
+ if ale#Has('win32') && l:executable =~? 'cmd\.js$'
+ " For Windows, if we detect an standard.js script, we need to execute
+ " it with node, or the file can be opened with a text editor.
+ let l:head = 'node ' . ale#Escape(l:executable)
+ else
+ let l:head = ale#Escape(l:executable)
+ endif
+
return {
- \ 'command': ale#Escape(l:executable)
+ \ 'command': l:head
\ . ' --fix %t',
\ 'read_temporary_file': 1,
\}
diff --git a/test/eslint-test-files/react-app/node_modules/standard/bin/cmd.js b/test/eslint-test-files/react-app/node_modules/standard/bin/cmd.js
new file mode 100644
index 00000000..e69de29b
--- /dev/null
+++ b/test/eslint-test-files/react-app/node_modules/standard/bin/cmd.js
diff --git a/test/fixers/test_standard_fixer_callback.vader b/test/fixers/test_standard_fixer_callback.vader
new file mode 100644
index 00000000..934b07b8
--- /dev/null
+++ b/test/fixers/test_standard_fixer_callback.vader
@@ -0,0 +1,32 @@
+Before:
+ call ale#test#SetDirectory('/testplugin/test/fixers')
+
+After:
+ let g:ale_has_override = {}
+ call ale#test#RestoreDirectory()
+
+Execute(The path to standard.js should be run on Unix):
+ call ale#test#SetFilename('../eslint-test-files/react-app/subdir/testfile.js')
+
+ AssertEqual
+ \ {
+ \ 'read_temporary_file': 1,
+ \ 'command':
+ \ ale#Escape(simplify(g:dir . '/../eslint-test-files/react-app/node_modules/standard/bin/cmd.js'))
+ \ . ' --fix %t',
+ \ },
+ \ ale#fixers#standard#Fix(bufnr(''))
+
+Execute(The standard fixer with standard.js should be run with node on Windows):
+ call ale#test#SetFilename('../eslint-test-files/react-app/subdir/testfile.js')
+ let g:ale_has_override['win32'] = 1
+
+ " We have to execute the file with node.
+ AssertEqual
+ \ {
+ \ 'read_temporary_file': 1,
+ \ 'command': 'node '
+ \ . ale#Escape(simplify(g:dir . '/../eslint-test-files/react-app/node_modules/standard/bin/cmd.js'))
+ \ . ' --fix %t',
+ \ },
+ \ ale#fixers#standard#Fix(bufnr(''))