diff options
| author | Kevin Locke <kevin@kevinlocke.name> | 2019-02-10 20:37:13 -0700 |
|---|---|---|
| committer | Kevin Locke <kevin@kevinlocke.name> | 2019-02-12 10:45:26 -0700 |
| commit | a6caa85a58d81aa4cd47172979a9c94aa8a902c6 (patch) | |
| tree | b05c7aa83a50e1b8fb21838b59d6006a24795a7e /test | |
| parent | bf196ba17c9e261e4e3a9dba64260c6d0b2c8af9 (diff) | |
| download | ale-a6caa85a58d81aa4cd47172979a9c94aa8a902c6.zip | |
pylama: Use %s instead of %t
Although using %t to lint changes was desirable, many pylama checks use
surrounding paths and file contents (e.g. C0103 module name, E0402
relative import beyond top, etc.) The more such errors I find during
testing, the less %t seems like a good idea. Switch to %s.
Also set `lint_file` to 1 and mark Pylama as a file linter in the docs.
Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
Diffstat (limited to 'test')
| -rw-r--r-- | test/command_callback/test_pylama_command_callback.vader | 2 | ||||
| -rw-r--r-- | test/handler/test_pylama_handler.vader | 19 |
2 files changed, 1 insertions, 20 deletions
diff --git a/test/command_callback/test_pylama_command_callback.vader b/test/command_callback/test_pylama_command_callback.vader index a24b55f8..417cb5c9 100644 --- a/test/command_callback/test_pylama_command_callback.vader +++ b/test/command_callback/test_pylama_command_callback.vader @@ -3,7 +3,7 @@ Before: call ale#test#SetFilename('test.py') let b:bin_dir = has('win32') ? 'Scripts' : 'bin' - let b:command_tail = ' %t' + let b:command_tail = ' %s' After: unlet! b:bin_dir diff --git a/test/handler/test_pylama_handler.vader b/test/handler/test_pylama_handler.vader index 854765db..d21c65d3 100644 --- a/test/handler/test_pylama_handler.vader +++ b/test/handler/test_pylama_handler.vader @@ -191,22 +191,3 @@ Execute(The pylama handler should handle message codes followed by a colon): \ ale_linters#python#pylama#Handle(bufnr(''), [ \ 'index.py:31:1: E800: Found commented out code: # needs_sphinx = ''1.0'' [eradicate]', \ ]) - -" The directory created for %t may not comply with pylint module name config. -" This should not be reported to users. -Execute(The pylama handler should ignore C0103 from temp dir, not others): - AssertEqual - \ [ - \ { - \ 'lnum': 29, - \ 'col': 0, - \ 'code': 'C0103', - \ 'type': 'W', - \ 'sub_type': 'style', - \ 'text': 'Constant name "badname" doesn''t conform to UPPER_CASE naming style [pylint]', - \ }, - \ ], - \ ale_linters#python#pylama#Handle(bufnr(''), [ - \ '../../../../tmp/vmynR33/456/__init__.py:1:0: C0103 Module name "456" doesn''t conform to snake_case naming style [pylint]', - \ '../../../../tmp/vmynR33/456/__init__.py:29:0: C0103 Constant name "badname" doesn''t conform to UPPER_CASE naming style [pylint]', - \ ]) |