#711 - Make the gcc executables configurable

3 files changed, 94 insertions, 8 deletions

diff --git a/test/command_callback/test_c_gcc_command_callbacks.vader b/test/command_callback/test_c_gcc_command_callbacks.vader
new file mode 100644
index 00000000..8038f410
--- /dev/null
+++ b/test/command_callback/test_c_gcc_command_callbacks.vader
@@ -0,0 +1,39 @@
+Before:
+  Save g:ale_c_gcc_executable
+  Save g:ale_c_gcc_options
+
+  unlet! g:ale_c_gcc_executable
+  unlet! b:ale_c_gcc_executable
+  unlet! g:ale_c_gcc_options
+  unlet! b:ale_c_gcc_options
+
+  runtime ale_linters/c/gcc.vim
+
+  let b:command_tail = ' -S -x c -fsyntax-only -iquote'
+  \   . ' ' . ale#Escape(getcwd())
+  \   . ' -std=c11 -Wall -'
+
+After:
+  Restore
+  unlet! b:command_tail
+  unlet! b:ale_c_gcc_executable
+  unlet! b:ale_c_gcc_options
+  call ale#linter#Reset()
+
+Execute(The executable should be configurable):
+  AssertEqual 'gcc', ale_linters#c#gcc#GetExecutable(bufnr(''))
+
+  let b:ale_c_gcc_executable = 'foobar'
+
+  AssertEqual 'foobar', ale_linters#c#gcc#GetExecutable(bufnr(''))
+
+Execute(The executable should be used in the command):
+  AssertEqual
+  \ ale#Escape('gcc') . b:command_tail,
+  \ ale_linters#c#gcc#GetCommand(bufnr(''))
+
+  let b:ale_c_gcc_executable = 'foobar'
+
+  AssertEqual
+  \ ale#Escape('foobar') . b:command_tail,
+  \ ale_linters#c#gcc#GetCommand(bufnr(''))
diff --git a/test/command_callback/test_cpp_gcc_command_callbacks.vader b/test/command_callback/test_cpp_gcc_command_callbacks.vader
new file mode 100644
index 00000000..9ab4d5cb
--- /dev/null
+++ b/test/command_callback/test_cpp_gcc_command_callbacks.vader
@@ -0,0 +1,39 @@
+Before:
+  Save g:ale_cpp_gcc_executable
+  Save g:ale_cpp_gcc_options
+
+  unlet! g:ale_cpp_gcc_executable
+  unlet! b:ale_cpp_gcc_executable
+  unlet! g:ale_cpp_gcc_options
+  unlet! b:ale_cpp_gcc_options
+
+  runtime ale_linters/cpp/gcc.vim
+
+  let b:command_tail = ' -S -x c++ -fsyntax-only -iquote'
+  \   . ' ' . ale#Escape(getcwd())
+  \   . ' -std=c++14 -Wall -'
+
+After:
+  Restore
+  unlet! b:command_tail
+  unlet! b:ale_cpp_gcc_executable
+  unlet! b:ale_cpp_gcc_options
+  call ale#linter#Reset()
+
+Execute(The executable should be configurable):
+  AssertEqual 'gcc', ale_linters#cpp#gcc#GetExecutable(bufnr(''))
+
+  let b:ale_cpp_gcc_executable = 'foobar'
+
+  AssertEqual 'foobar', ale_linters#cpp#gcc#GetExecutable(bufnr(''))
+
+Execute(The executable should be used in the command):
+  AssertEqual
+  \ ale#Escape('gcc') . b:command_tail,
+  \ ale_linters#cpp#gcc#GetCommand(bufnr(''))
+
+  let b:ale_cpp_gcc_executable = 'foobar'
+
+  AssertEqual
+  \ ale#Escape('foobar') . b:command_tail,
+  \ ale_linters#cpp#gcc#GetCommand(bufnr(''))
diff --git a/test/test_c_import_paths.vader b/test/test_c_import_paths.vader
index ae6375f5..862ec151 100644
--- a/test/test_c_import_paths.vader
+++ b/test/test_c_import_paths.vader
@@ -37,7 +37,8 @@ Execute(The C GCC handler should include 'include' directories for projects with
   call ale#test#SetFilename('test_c_projects/makefile_project/subdir/file.c')
 
   AssertEqual
-  \   'gcc -S -x c -fsyntax-only '
+  \ ale#Escape('gcc')
+  \   . ' -S -x c -fsyntax-only '
   \   . '-iquote ' . ale#Escape(g:dir .  '/test_c_projects/makefile_project/subdir') . ' '
   \   . ' -I' . ale#Escape(g:dir .  '/test_c_projects/makefile_project/include') . ' '
   \   . ' -'
@@ -49,7 +50,8 @@ Execute(The C GCC handler should include 'include' directories for projects with
   call ale#test#SetFilename('test_c_projects/configure_project/subdir/file.c')
 
   AssertEqual
-  \   'gcc -S -x c -fsyntax-only '
+  \ ale#Escape('gcc')
+  \   . ' -S -x c -fsyntax-only '
   \   . '-iquote ' . ale#Escape(g:dir .  '/test_c_projects/configure_project/subdir') . ' '
   \   . ' -I' . ale#Escape(g:dir .  '/test_c_projects/configure_project/include') . ' '
   \   . ' -'
@@ -61,7 +63,8 @@ Execute(The C GCC handler should include root directories for projects with .h f
   call ale#test#SetFilename('test_c_projects/h_file_project/subdir/file.c')
 
   AssertEqual
-  \   'gcc -S -x c -fsyntax-only '
+  \ ale#Escape('gcc')
+  \   . ' -S -x c -fsyntax-only '
   \   . '-iquote ' . ale#Escape(g:dir .  '/test_c_projects/h_file_project/subdir') . ' '
   \   . ' -I' . ale#Escape(g:dir .  '/test_c_projects/h_file_project') . ' '
   \   . ' -'
@@ -73,7 +76,8 @@ Execute(The C GCC handler should include root directories for projects with .hpp
   call ale#test#SetFilename('test_c_projects/hpp_file_project/subdir/file.c')
 
   AssertEqual
-  \   'gcc -S -x c -fsyntax-only '
+  \ ale#Escape('gcc')
+  \   . ' -S -x c -fsyntax-only '
   \   . '-iquote ' . ale#Escape(g:dir .  '/test_c_projects/hpp_file_project/subdir') . ' '
   \   . ' -I' . ale#Escape(g:dir .  '/test_c_projects/hpp_file_project') . ' '
   \   . ' -'
@@ -137,7 +141,8 @@ Execute(The C++ GCC handler should include 'include' directories for projects wi
   call ale#test#SetFilename('test_c_projects/makefile_project/subdir/file.cpp')
 
   AssertEqual
-  \   'gcc -S -x c++ -fsyntax-only '
+  \   ale#Escape('gcc')
+  \   . ' -S -x c++ -fsyntax-only '
   \   . '-iquote ' . ale#Escape(g:dir .  '/test_c_projects/makefile_project/subdir') . ' '
   \   . ' -I' . ale#Escape(g:dir .  '/test_c_projects/makefile_project/include') . ' '
   \   . ' -'
@@ -149,7 +154,8 @@ Execute(The C++ GCC handler should include 'include' directories for projects wi
   call ale#test#SetFilename('test_c_projects/configure_project/subdir/file.cpp')
 
   AssertEqual
-  \   'gcc -S -x c++ -fsyntax-only '
+  \   ale#Escape('gcc')
+  \   . ' -S -x c++ -fsyntax-only '
   \   . '-iquote ' . ale#Escape(g:dir .  '/test_c_projects/configure_project/subdir') . ' '
   \   . ' -I' . ale#Escape(g:dir .  '/test_c_projects/configure_project/include') . ' '
   \   . ' -'
@@ -161,7 +167,8 @@ Execute(The C++ GCC handler should include root directories for projects with .h
   call ale#test#SetFilename('test_c_projects/h_file_project/subdir/file.cpp')
 
   AssertEqual
-  \   'gcc -S -x c++ -fsyntax-only '
+  \   ale#Escape('gcc')
+  \   . ' -S -x c++ -fsyntax-only '
   \   . '-iquote ' . ale#Escape(g:dir .  '/test_c_projects/h_file_project/subdir') . ' '
   \   . ' -I' . ale#Escape(g:dir .  '/test_c_projects/h_file_project') . ' '
   \   . ' -'
@@ -173,7 +180,8 @@ Execute(The C++ GCC handler should include root directories for projects with .h
   call ale#test#SetFilename('test_c_projects/hpp_file_project/subdir/file.cpp')
 
   AssertEqual
-  \   'gcc -S -x c++ -fsyntax-only '
+  \   ale#Escape('gcc')
+  \   . ' -S -x c++ -fsyntax-only '
   \   . '-iquote ' . ale#Escape(g:dir .  '/test_c_projects/hpp_file_project/subdir') . ' '
   \   . ' -I' . ale#Escape(g:dir .  '/test_c_projects/hpp_file_project') . ' '
   \   . ' -'