Add the dockerfile_lint linter for Dockerfiles (#1971)

* Add the dockerfile_lint linter for Dockerfiles

2 files changed, 127 insertions, 0 deletions

diff --git a/test/command_callback/test_dockerfile_lint_command_callback.vader b/test/command_callback/test_dockerfile_lint_command_callback.vader
new file mode 100644
index 00000000..abc32e0d
--- /dev/null
+++ b/test/command_callback/test_dockerfile_lint_command_callback.vader
@@ -0,0 +1,19 @@
+Before:
+  call ale#assert#SetUpLinterTest('dockerfile', 'dockerfile_lint')
+
+After:
+  call ale#assert#TearDownLinterTest()
+
+Execute(The default command should be correct):
+  AssertLinter 'dockerfile_lint', ale#Escape('dockerfile_lint') . ' -p -j -f %t'
+
+Execute(The executable should be configurable):
+  let b:ale_dockerfile_dockerfile_lint_executable = 'foobar'
+
+  AssertLinter 'foobar', ale#Escape('foobar') . ' -p -j -f %t'
+
+Execute(The options should be configurable):
+  let b:ale_dockerfile_dockerfile_lint_options = '-r additional.yaml'
+
+  AssertLinter 'dockerfile_lint', ale#Escape('dockerfile_lint') . ' -r additional.yaml -p -j -f %t'
+
diff --git a/test/handler/test_dockerfile_lint_handler.vader b/test/handler/test_dockerfile_lint_handler.vader
new file mode 100644
index 00000000..619b7bde
--- /dev/null
+++ b/test/handler/test_dockerfile_lint_handler.vader
@@ -0,0 +1,108 @@
+Before:
+  runtime ale_linters/dockerfile/dockerfile_lint.vim
+
+After:
+  call ale#linter#Reset()
+
+Execute(The dockerfile_lint handler should handle broken JSON):
+  AssertEqual
+  \ [],
+  \ ale_linters#dockerfile#dockerfile_lint#Handle(bufnr(''), ["{asdf"])
+
+Execute(The dockerfile_lint handler should handle an empty string response):
+  AssertEqual
+  \ [],
+  \ ale_linters#dockerfile#dockerfile_lint#Handle(bufnr(''), [])
+
+Execute(The dockerfile_lint handler should handle an empty result, even if it shouldn't happen):
+  AssertEqual
+  \ [],
+  \ ale_linters#dockerfile#dockerfile_lint#Handle(bufnr(''), ["{}"])
+
+Execute(The dockerfile_lint handler should handle a normal example):
+  AssertEqual
+  \ [
+  \   {
+  \     'lnum': -1,
+  \     'type': 'E',
+  \     'text': "Required LABEL name/key 'Name' is not defined",
+  \   },
+  \   {
+  \     'lnum': -1,
+  \     'type': 'E',
+  \     'text': "Required LABEL name/key 'Version' is not defined",
+  \   },
+  \   {
+  \     'lnum': 3,
+  \     'type': 'I',
+  \     'text': "the MAINTAINER command is deprecated. MAINTAINER is deprecated in favor of using LABEL since Docker v1.13.0",
+  \   },
+  \   {
+  \     'lnum': -1,
+  \     'type': 'I',
+  \     'text': "There is no 'CMD' instruction",
+  \   },
+  \ ],
+  \ ale_linters#dockerfile#dockerfile_lint#Handle(bufnr(''), [
+  \  '{',
+  \  '  "error": {',
+  \  '    "count": 2,',
+  \  '    "data": [',
+  \  '      {',
+  \  "        \"message\": \"Required LABEL name/key 'Name' is not defined\",",
+  \  '        "line": -1,',
+  \  '        "level": "error",',
+  \  '        "lineContent": "",',
+  \  '        "reference_url": [',
+  \  '          "http://docs.projectatomic.io/container-best-practices/#",',
+  \  '          "_recommended_labels_for_your_project"',
+  \  '        ]',
+  \  '      },',
+  \  '      {',
+  \  "        \"message\": \"Required LABEL name/key 'Version' is not defined\",",
+  \  '        "line": -1,',
+  \  '        "level": "error",',
+  \  '        "lineContent": "",',
+  \  '        "reference_url": [',
+  \  '          "http://docs.projectatomic.io/container-best-practices/#",',
+  \  '          "_recommended_labels_for_your_project"',
+  \  '        ]',
+  \  '      }',
+  \  '    ]',
+  \  '  },',
+  \  '  "warn": {',
+  \  '    "count": 0,',
+  \  '    "data": []',
+  \  '  },',
+  \  '  "info": {',
+  \  '    "count": 2,',
+  \  '    "data": [',
+  \  '      {',
+  \  '        "label": "maintainer_deprecated",',
+  \  '        "regex": {},',
+  \  '        "level": "info",',
+  \  '        "message": "the MAINTAINER command is deprecated",',
+  \  '        "description": "MAINTAINER is deprecated in favor of using LABEL since Docker v1.13.0",',
+  \  '        "reference_url": [',
+  \  '          "https://github.com/docker/cli/blob/master/docs/deprecated.md",',
+  \  '          "#maintainer-in-dockerfile"',
+  \  '        ],',
+  \  '        "lineContent": "MAINTAINER Alexander Olofsson <ace@haxalot.com>",',
+  \  '        "line": 3',
+  \  '      },',
+  \  '      {',
+  \  '        "instruction": "CMD",',
+  \  '        "count": 1,',
+  \  '        "level": "info",',
+  \  "        \"message\": \"There is no 'CMD' instruction\",",
+  \  '        "description": "None",',
+  \  '        "reference_url": [',
+  \  '          "https://docs.docker.com/engine/reference/builder/",',
+  \  '          "#cmd"',
+  \  '        ]',
+  \  '      }',
+  \  '    ]',
+  \  '  },',
+  \  '  "summary": []',
+  \  '}',
+  \ ])