#3599 - Use ale_root instead of ale_lsp_root

The `ale_lsp_root` setting is now deprecated, and `ale_root` should be
used instead. The setting will be used for both setting the root easily
for LSP linters, and for running other linters over whole projects.

1 files changed, 39 insertions, 11 deletions

diff --git a/test/lsp/test_lsp_root_detection.vader b/test/lsp/test_lsp_root_detection.vader
index 3de4d825..291300f0 100644
--- a/test/lsp/test_lsp_root_detection.vader
+++ b/test/lsp/test_lsp_root_detection.vader
@@ -1,4 +1,12 @@
 Before:
+  Save g:ale_lsp_root
+  Save g:ale_root
+  Save b:ale_lsp_root
+  Save b:ale_root
+
+  unlet! g:ale_lsp_root
+  let g:ale_root = {}
+
   call ale#assert#SetUpLinterTest('c', 'clangd')
 
   function! Hook1(buffer)
@@ -6,52 +14,72 @@ Before:
   endfunction
 
 After:
-  let g:ale_lsp_root = {}
-  unlet! b:ale_lsp_root
+  Restore
+
   delfunction Hook1
 
   call ale#assert#TearDownLinterTest()
 
 Execute(The buffer-specific variable can be a string):
-  let b:ale_lsp_root = '/some/path'
+  let b:ale_root = '/some/path'
   call ale#test#SetFilename('other-file.c')
 
   AssertLSPProject '/some/path'
 
 Execute(The buffer-specific variable can be a dictionary):
-  let b:ale_lsp_root = {'clangd': '/some/path', 'golangserver': '/other/path'}
+  let b:ale_root = {'clangd': '/some/path', 'golangserver': '/other/path'}
   call ale#test#SetFilename('other-file.c')
 
   AssertLSPProject '/some/path'
 
 Execute(The buffer-specific variable can have funcrefs):
-  let b:ale_lsp_root = {'clangd': function('Hook1'), 'golangserver': '/path'}
+  let b:ale_root = {'clangd': function('Hook1'), 'golangserver': '/path'}
   call ale#test#SetFilename('other-file.c')
 
   AssertLSPProject 'abc123'
 
+Execute(The buffer-specific variable can be the old ale_lsp_root setting):
+  let b:ale_lsp_root = '/some/path'
+  call ale#test#SetFilename('other-file.c')
+
+  AssertLSPProject '/some/path'
+
 Execute(The global variable can be a dictionary):
-  let g:ale_lsp_root = {'clangd': '/some/path', 'golangserver': '/other/path'}
+  let g:ale_root = {'clangd': '/some/path', 'golangserver': '/other/path'}
   call ale#test#SetFilename('other-file.c')
 
   AssertLSPProject '/some/path'
 
 Execute(The global variable can have funcrefs):
-  let g:ale_lsp_root = {'clangd': function('Hook1'), 'golangserver': '/path'}
+  let g:ale_root = {'clangd': function('Hook1'), 'golangserver': '/path'}
   call ale#test#SetFilename('other-file.c')
 
   AssertLSPProject 'abc123'
 
 Execute(The buffer-specific variable overrides the global variable):
-  let b:ale_lsp_root = {'clangd': '/some/path', 'golangserver': '/other/path'}
-  let g:ale_lsp_root = {'clangd': '/not/this/path', 'golangserver': '/elsewhere'}
+  let b:ale_root = {'clangd': '/some/path', 'golangserver': '/other/path'}
+  let g:ale_root = {'clangd': '/not/this/path', 'golangserver': '/elsewhere'}
   call ale#test#SetFilename('other-file.c')
 
   AssertLSPProject '/some/path'
 
 Execute(The global variable is queried if the buffer-specific has no value):
-  let b:ale_lsp_root = {'golangserver': '/other/path'}
-  let g:ale_lsp_root = {'clangd': '/some/path', 'golangserver': '/elsewhere'}
+  let b:ale_root = {'golangserver': '/other/path'}
+  let g:ale_root = {'clangd': '/some/path', 'golangserver': '/elsewhere'}
+  call ale#test#SetFilename('other-file.c')
+
+  AssertLSPProject '/some/path'
+
+Execute(The global variable can be the old ale_lsp_root setting):
+  let g:ale_root = {}
+  let g:ale_lsp_root = {'clangd': '/some/path', 'golangserver': '/other/path'}
+  call ale#test#SetFilename('other-file.c')
+
+  AssertLSPProject '/some/path'
+
+Execute(A non-empty ale_root setting should replace the old ale_lsp_root):
+  let g:ale_root = {'clangd': '/some/path', 'golangserver': '/other/path'}
+  let g:ale_lsp_root = {'clangd': '/xxx', 'golangserver': '/xxx'}
   call ale#test#SetFilename('other-file.c')
 
   AssertLSPProject '/some/path'