diff options
| author | Richard Jonas <richard.jonas.76@gmail.com> | 2022-05-04 13:05:32 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-05-04 20:05:32 +0900 |
| commit | 9e1351499c6b9a43a5fddd535f82605bde237e5e (patch) | |
| tree | cbe4ebeca2b74681db7291a0b10d8c03212c3aad /test/handler | |
| parent | 4e6a7debb444d702d12a9ee8b135c1c4ad09ff0a (diff) | |
| download | ale-9e1351499c6b9a43a5fddd535f82605bde237e5e.zip | |
Handle golangci_lint warning and error messages correctly (#4182)
* Handle golangci_lint warning and error messages correctly
* Fix linter warning
Co-authored-by: Richard Jonas <richard.jonas@derivco.se>
Diffstat (limited to 'test/handler')
| -rw-r--r-- | test/handler/test_golangci_lint_handler.vader | 39 |
1 files changed, 34 insertions, 5 deletions
diff --git a/test/handler/test_golangci_lint_handler.vader b/test/handler/test_golangci_lint_handler.vader index fb6841f4..58815f56 100644 --- a/test/handler/test_golangci_lint_handler.vader +++ b/test/handler/test_golangci_lint_handler.vader @@ -13,19 +13,21 @@ Execute (The golangci-lint handler should handle names with spaces): \ 'C:\something\file with spaces.go', \ '12', \ '3', - \ 'expected ''package'', found ''IDENT'' gibberish (staticcheck)', + \ 'expected ''package'', found ''IDENT'' gibberish', + \ 'staticcheck', \ ], \ [ \ 'C:\something\file with spaces.go', \ '37', \ '5', - \ 'expected ''package'', found ''IDENT'' gibberish (golint)', + \ 'expected ''package'', found ''IDENT'' gibberish', + \ 'golint', \ ], \ ], \ map(ale_linters#go#golangci_lint#GetMatches([ \ 'C:\something\file with spaces.go:12:3: expected ''package'', found ''IDENT'' gibberish (staticcheck)', \ 'C:\something\file with spaces.go:37:5: expected ''package'', found ''IDENT'' gibberish (golint)', - \ ]), 'v:val[1:4]') + \ ]), 'v:val[1:5]') Execute (The golangci-lint handler should handle paths correctly): call ale#test#SetFilename('app/test.go') @@ -38,14 +40,14 @@ Execute (The golangci-lint handler should handle paths correctly): \ 'lnum': 12, \ 'col': 3, \ 'text': 'expected ''package'', found ''IDENT'' gibberish (staticcheck)', - \ 'type': 'E', + \ 'type': 'W', \ 'filename': ale#path#Simplify(expand('%:p:h') . '/test.go'), \ }, \ { \ 'lnum': 37, \ 'col': 5, \ 'text': 'expected ''package'', found ''IDENT'' gibberish (golint)', - \ 'type': 'E', + \ 'type': 'W', \ 'filename': ale#path#Simplify(expand('%:p:h') . '/test.go'), \ }, \ ], @@ -53,3 +55,30 @@ Execute (The golangci-lint handler should handle paths correctly): \ file . ':12:3: expected ''package'', found ''IDENT'' gibberish (staticcheck)', \ file . ':37:5: expected ''package'', found ''IDENT'' gibberish (golint)', \ ]) + +Execute (The golangci-lint handler should handle only typecheck lines as errors): + call ale#test#SetFilename('app/main.go') + + let file = ale#path#GetAbsPath(expand('%:p:h'), 'test.go') + + AssertEqual + \ [ + \ { + \ 'lnum': 30, + \ 'col': 5, + \ 'text': 'variable ''err'' is not used (typecheck)', + \ 'type': 'E', + \ 'filename': ale#path#Simplify(expand('%:p:h') . '/test.go'), + \ }, + \ { + \ 'lnum': 505, + \ 'col': 75, + \ 'text': 'Magic number: 404, in <argument> detected (gomnd)', + \ 'type': 'W', + \ 'filename': ale#path#Simplify(expand('%:p:h') . '/test.go'), + \ } + \ ], + \ ale_linters#go#golangci_lint#Handler(bufnr(''), [ + \ file . ':30:5: variable ''err'' is not used (typecheck)', + \ file . ':505:75: Magic number: 404, in <argument> detected (gomnd)', + \ ]) |