diff options
author | SkrrtBacharach <61713784+SkrrtBacharach@users.noreply.github.com> | 2023-04-07 01:19:58 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-04-07 09:19:58 +0900 |
commit | 57254db9ef1e0b0bf21466ed2d3ebaf60338768f (patch) | |
tree | 60f82e2b05e88069f96ca4ead910a2be5f5fb4a4 /test/handler | |
parent | b0ba31f88e09c033630ac15ae07143af7f658072 (diff) | |
download | ale-57254db9ef1e0b0bf21466ed2d3ebaf60338768f.zip |
Fix error from ansible-lint versions >=6.11.0. (#4492)
* Fix error from ansible-lint versions >=6.11.0.
The JSON output format of ansible-lint has changed since
6.11.0. Issue locations can have either a 'positions' or
a 'lines' member, rather than just a 'lines' member as it
was before. This fix checks which member is present, and
passes that member name to subsequent dictionary lookups.
The error was caused by the following change:
https://github.com/ansible/ansible-lint/pull/2897
* Add ansible-lint test to check each type of ansible-lint issue json.
* Change long single-line JSON in ansible test into multiline JSON.
* Fix linting errors in ansible_lint.vim.
Diffstat (limited to 'test/handler')
-rw-r--r-- | test/handler/test_ansible_lint_handler.vader | 66 |
1 files changed, 66 insertions, 0 deletions
diff --git a/test/handler/test_ansible_lint_handler.vader b/test/handler/test_ansible_lint_handler.vader index fbc38f30..92e11332 100644 --- a/test/handler/test_ansible_lint_handler.vader +++ b/test/handler/test_ansible_lint_handler.vader @@ -86,6 +86,72 @@ Execute (The ansible-lint handler for version group >=5 should handle names with \ fnamemodify(tempname(), ':h') . "/test playbook.yml:3:148: [syntax-check] [VERY_HIGH] 'var' is not a valid attribute for a Play", \ ]) +Execute (The ansible-lint handler should work with issues with positions and lines members): + AssertEqual + \ [ + \ { + \ 'lnum': 6, + \ 'col': 7, + \ 'code': 'major', + \ 'type': 'W', + \ 'text': "syntax-check[specific]", + \ 'detail': 'fakedesc', + \ }, + \ { + \ 'lnum': 6, + \ 'col': 0, + \ 'code': 'major', + \ 'type': 'W', + \ 'text': 'fqcn[action-core]', + \ 'detail': 'fakedesc2' + \ } + \ ], + \ ale_linters#ansible#ansible_lint#Handle(bufnr(''), [6, 11, 0], [ + \ '[', + \ ' {', + \ ' "type": "issue",', + \ ' "check_name": "syntax-check[specific]",', + \ ' "categories": [', + \ ' "core",', + \ ' "unskippable"', + \ ' ],', + \ ' "url": "https://ansible-lint.readthedocs.io/rules/syntax-check/",', + \ ' "severity": "major",', + \ ' "description": "fakedesc",', + \ ' "fingerprint": "4",', + \ ' "location": {', + \ ' "path": "test playbook.yml",', + \ ' "positions": {', + \ ' "begin": {', + \ ' "line": 6,', + \ ' "column": 7', + \ ' }', + \ ' }', + \ ' }', + \ ' },', + \ ' {', + \ ' "type": "issue",', + \ ' "check_name": "fqcn[action-core]",', + \ ' "categories": [', + \ ' "formatting"', + \ ' ],', + \ ' "url": "https://ansible-lint.readthedocs.io/rules/fqcn/",', + \ ' "severity": "major",', + \ ' "description": "fakedesc2",', + \ ' "fingerprint": "f",', + \ ' "location": {', + \ ' "path": "test playbook.yml",', + \ ' "lines": {', + \ ' "begin": 6', + \ ' }', + \ ' },', + \ ' "content": {', + \ ' "body": "Use `ansible.builtin.command` or `ansible.legacy.command` instead."', + \ ' }', + \ ' }', + \ ']' + \ ]) + Execute (The ansible-lint handler should ignore errors from other files): AssertEqual \ [ |