summaryrefslogtreecommitdiff
path: root/test/fixers
diff options
context:
space:
mode:
authorawang <ts826848+github@gmail.com>2021-05-25 00:37:09 +0000
committerGitHub <noreply@github.com>2021-05-25 09:37:09 +0900
commitbf1c30f585fe4ff68596d93230964b862e8d5940 (patch)
treefe0242ab47fd9f61a6e21d1d6684cd11f216b463 /test/fixers
parent6ef5bf308c91e5960ae84460329bf39287b17e23 (diff)
downloadale-bf1c30f585fe4ff68596d93230964b862e8d5940.zip
Use stdin/out for cmake-format (#3725)
cmake-format added support for reading from/outputting to stdin/out as of v0.3.6, released 2018-04-10 (commit 2e2aff2) [0]. Reading from stdin is preferable over reading from a temporary file because when given a concrete file cmake-format will look for its config file (.cmake-format.py or similar) in the parent directories of the provided file. If the temporary file is off in a tmpdir somewhere (e.g., /tmp on *nix), cmake-format will almost certainly not come across the user's intended format configuration file, making it appear that cmake-format is ignoring the config file. If cmake-format reads from stdin, though, it'll look for its config file in its current working directory and its parent directories, in a similar manner to clang-format. This has a much higher chance of running across the intended config file. [0]: https://github.com/cheshirekow/cmake_format/releases/tag/v0.3.6 Co-authored-by: Alex Wang <ts826848@gmail.com>
Diffstat (limited to 'test/fixers')
-rw-r--r--test/fixers/test_cmakeformat_fixer_callback.vader8
1 files changed, 2 insertions, 6 deletions
diff --git a/test/fixers/test_cmakeformat_fixer_callback.vader b/test/fixers/test_cmakeformat_fixer_callback.vader
index 9263d6fa..545fe067 100644
--- a/test/fixers/test_cmakeformat_fixer_callback.vader
+++ b/test/fixers/test_cmakeformat_fixer_callback.vader
@@ -18,10 +18,8 @@ Execute(The cmakeformat callback should return the correct default values):
AssertEqual
\ {
- \ 'read_temporary_file': 1,
\ 'command': ale#Escape('xxxinvalid')
- \ . ' -i '
- \ . ' %t',
+ \ . ' -'
\ },
\ ale#fixers#cmakeformat#Fix(bufnr(''))
@@ -31,10 +29,8 @@ Execute(The cmakeformat callback should include custom cmakeformat options):
AssertEqual
\ {
- \ 'read_temporary_file': 1,
\ 'command': ale#Escape('xxxinvalid')
- \ . ' -i '
\ . ' ' . g:ale_cmake_cmakeformat_options
- \ . ' %t',
+ \ . ' -',
\ },
\ ale#fixers#cmakeformat#Fix(bufnr(''))